Page MenuHomePhabricator

[LIB] WikibaseDataModelSerialization tests fail because of outdated dependencies (and the CI is dead)
Closed, ResolvedPublic

Description

It appears that tests in the library WikibaseDataModelSerialization have been failing for some time now due to out of date dependencies (see original report below). These errors should be fixed, and indications of failing builds should be up to date.

Acceptance Criteria

  • Tests pass in WikibaseDataModelSerialization
  • Ensure that badges on readme.md are up to date or remove them to prevent misleading potential contributers

Notes:

Original Report:

I wanted to work on a PR to address T323618 so I tried:

git clone https://github.com/wmde/WikibaseDataModelSerialization
composer install
composer test

Only to discover that the tests fail with a bunch of Error: Class 'Wikibase\DataModel\Entity\NumericPropertyId' not found errors.

I did some digging and this is apparently because Wikibase-DataModel-Serialization depends on Wikibase-DataModel, where the NumericPropertyId class has been introduced in T289125. However Wikibase-DataModel has not had a release since and Wikibase-DataModel-Serialization has been changed to use the new class in a14086394e8cd813a29ddcae6c9338dc9665a1f3 without updating the wikibase/data-model dependency in composer.json.

So I think a new version of Wikibase-DataModel should be released and the composer.json of Wikibase-DataModel-Serialization should be updated accordingly. I was initially really confused why the README proudly declared "build passing" but apparently the Travis CI is dead, having last run 2 years ago.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The Travis CI apparently came back to life and emailed me about a failed build (which it numbers as build #1 somehow). But we should still remove it – it’s still broken with the same error.

We should also try to clarify the contribution instructions – sending pull requests on that repository isn’t right (anymore), it’s now integrated into Wikibase.git and we just export the lib/packages/wikibase/data-model-serialization/ subtree from there, so any changes should be sent on Gerrit.

We should also try to clarify the contribution instructions – sending pull requests on that repository isn’t right (anymore), it’s now integrated into Wikibase.git and we just export the lib/packages/wikibase/data-model-serialization/ subtree from there, so any changes should be sent on Gerrit.

These should probably be tracked under separate tasks, rather than this one.

Lucas_Werkmeister_WMDE renamed this task from WikibaseDataModelSerialization tests fail because of outdated dependencies (and the CI is dead) to [LIB] WikibaseDataModelSerialization tests fail because of outdated dependencies (and the CI is dead).Apr 12 2024, 12:44 PM
ItamarWMDE renamed this task from [LIB] WikibaseDataModelSerialization tests fail because of outdated dependencies (and the CI is dead) to [SW] [LIB] WikibaseDataModelSerialization tests fail because of outdated dependencies (and the CI is dead).Dec 6 2024, 11:25 AM
ItamarWMDE updated the task description. (Show Details)

Prio Notes:

Impact AreaAffected
production / end usersno
monitoringno
development effortsyes
onboarding effortsno
additional stakeholdersyes (volunteer contributors)
ItamarWMDE triaged this task as Medium priority.Dec 6 2024, 11:26 AM
ItamarWMDE renamed this task from [SW] [LIB] WikibaseDataModelSerialization tests fail because of outdated dependencies (and the CI is dead) to [LIB] WikibaseDataModelSerialization tests fail because of outdated dependencies (and the CI is dead).Dec 12 2024, 11:37 AM
ArthurTaylor added a subscriber: WMDE-leszek.

Looks like this was fixed by @WMDE-leszek's efforts in T381168 - the builds are passing and the dependencies and README was updated in 1109665. Marking this as resolved.