The first opening bracket of a tvar starting a line misses cm-mw-tag-translate class
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Pols12
	Dec 17 2022, 2:40 PM

Description

Follow-up of T284883: CodeMirror – support highlighting the new <tvar> tag syntax.

Steps to replicate the issue:

Open the 2010 Wikitext Editor, CodeMirror enabled, and type the following content:

<translate>
Hello <tvar name=world>world</tvar>

<tvar name=foo>Foo</tvar>
</translate>

What happens?:
Note the first opening bracket < for foo tvar is not green-colored, whereas the one of world tvar actually is.
When the tvar is at line start, the cm-mw-tag-translate class is not added to the leading bracket.

What should have happened instead?:
The bracket should be colored as world bracket, with cm-mw-tag-translate class.

Related Objects

Mentioned Here: T284883: CodeMirror – support highlighting the new <tvar> tag syntax

Event Timeline

Pols12 created this task.Dec 17 2022, 2:40 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptDec 17 2022, 2:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• JMcLeod_WMF removed a project: Community-Tech.Dec 19 2022, 3:04 PM

This bug does not exist any more.

I cannot reproduce at mediawiki.org, but I can still reproduce at meta.wikimedia.org, even in private browsing with &safemode=1.

At MetaWiki (issuing behavior):

<span role="presentation">
<span class=" cm-mw-exttag-bracket cm-mw-ext-tvar">&lt;</span>
<span class="cm-mw-tag-translate cm-mw-exttag-name cm-mw-ext-tvar">tvar </span>
<span class="cm-mw-tag-translate cm-mw-exttag-attribute cm-mw-ext-tvar">name=foo</span>
<span class="cm-mw-tag-translate cm-mw-exttag-bracket cm-mw-ext-tvar">&gt;</span>
<span class="cm-mw-tag-translate cm-mw-tag-tvar ">Foo</span>
<span class="cm-mw-tag-translate cm-mw-exttag-bracket cm-mw-ext-tvar">&lt;/</span>
<span class="cm-mw-tag-translate cm-mw-exttag-name cm-mw-ext-tvar">tvar</span>
<span class="cm-mw-tag-translate cm-mw-exttag-bracket cm-mw-ext-tvar">&gt;</span>
</span>

At MediaWiki.org (expected behavior):

<div class="cm-line">
<span class="cm-mw-tag-translate cm-mw-exttag-bracket cm-mw-ext-tvar">&lt;</span>
<span class="cm-mw-tag-translate cm-mw-exttag-name cm-mw-ext-tvar">tvar </span>
<span class="cm-mw-tag-translate cm-mw-exttag-attribute cm-mw-ext-tvar">name=foo</span>
<span class="cm-mw-tag-translate cm-mw-exttag-bracket cm-mw-ext-tvar">&gt;</span>
<span class="cm-mw-tag-translate cm-mw-tag-tvar">Foo</span>
<span class="cm-mw-tag-translate cm-mw-exttag-bracket cm-mw-ext-tvar">&lt;/</span>
<span class="cm-mw-tag-translate cm-mw-exttag-name cm-mw-ext-tvar">tvar</span>
<span class="cm-mw-tag-translate cm-mw-exttag-bracket cm-mw-ext-tvar">&gt;</span>
</div>

We notice the cm-mw-tag-translate class is missing from enclosing span.

Bhsd moved this task from Done to CodeMirror 5 (legacy) on the MediaWiki-extensions-CodeMirror board.Dec 5 2024, 11:08 PM

Bhsd unsubscribed.Dec 16 2024, 9:58 AM

The first opening bracket of a tvar starting a line misses cm-mw-tag-translate classOpen, Needs TriagePublicBUG REPORTActions

Description

Related Objects

Event Timeline

The first opening bracket of a tvar starting a line misses cm-mw-tag-translate class
Open, Needs TriagePublicBUG REPORT
Actions