Page MenuHomePhabricator

Hard-deprecate HTMLForm::*Text function (and remove in MW 1.44)
Closed, ResolvedPublic

Description

RELEASE-NOTES-1.38
* The HTMLForm methods getPreText, setPreText, addPreText, getPostText,
  setPostText, addPostText, getHeaderText, setHeaderText, addHeaderText,
  getFooterText, setFooterText and addFooterText have been renamed to
  getPreHtml, setPreHtml, addPreHtml, getPostHtml, setPostHtml, addPostHtml,
  getHeaderHtml, setHeaderHtml, addHeaderHtml, getFooterHtml, setFooterHtml and
  addFooterHtml respectively.
* The FormSpecialPage methods preText and postText have been renamed to preHtml
  and postHtml respectively.

This also includes HTMLForm::setIntro

CodeSearch (with false positives): https://codesearch.wmcloud.org/search/?q=%5Cb(getPreText%7CsetPreText%7CaddPreText%7CgetPostText%7CsetPostText%7CaddPostText%7CgetHeaderText%7CsetHeaderText%7CaddHeaderText%7CgetFooterText%7CsetFooterText%7CaddFooterText%7CsetIntro)%5Cb&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/UserVerificationmaster+4 -4
mediawiki/coremaster+14 -228
mediawiki/coremaster+69 -20
mediawiki/extensions/VisualDatamaster+9 -9
mediawiki/extensions/PagePropertiesmaster+5 -5
mediawiki/coremaster+8 -8
mediawiki/extensions/PageFormsmaster+3 -3
mediawiki/extensions/MathSearchmaster+3 -3
mediawiki/extensions/FanBoxesmaster+3 -3
mediawiki/extensions/StructuredNavigationmaster+2 -2
mediawiki/extensions/QuizGamemaster+2 -2
mediawiki/extensions/PollNYmaster+3 -3
mediawiki/extensions/WatchAnalyticsmaster+2 -2
mediawiki/extensions/UserExportmaster+2 -2
mediawiki/extensions/WatchSubpagesmaster+2 -2
mediawiki/extensions/PictureGamemaster+12 -2
mediawiki/extensions/Wikispeechmaster+5 -5
mediawiki/extensions/Surveymaster+1 -1
mediawiki/extensions/AdManagermaster+7 -7
mediawiki/extensions/RegexBlockmaster+4 -4
mediawiki/extensions/BulkBlockmaster+2 -2
mediawiki/extensions/BibManagermaster+1 -1
mediawiki/extensions/DeletePagesForGoodmaster+4 -4
mediawiki/coremaster+7 -7
mediawiki/extensions/ConfirmEditmaster+2 -2
mediawiki/extensions/Newslettermaster+5 -5
mediawiki/extensions/Collectionmaster+2 -2
mediawiki/extensions/ArticlePlaceholdermaster+2 -2
mediawiki/extensions/Interwikimaster+2 -2
mediawiki/extensions/Lintermaster+2 -2
mediawiki/extensions/Wikibasemaster+7 -7
mediawiki/extensions/WikibaseLexememaster+2 -2
mediawiki/extensions/OATHAuthmaster+2 -2
mediawiki/extensions/ApiFeatureUsagemaster+2 -2
mediawiki/extensions/GlobalBlockingmaster+3 -3
mediawiki/extensions/GrowthExperimentsmaster+9 -9
mediawiki/extensions/GlobalPreferencesmaster+1 -1
mediawiki/extensions/OAuthmaster+9 -9
mediawiki/extensions/ThrottleOverridemaster+2 -2
mediawiki/extensions/TranslationNotificationsmaster+1 -1
mediawiki/extensions/TemplateSandboxmaster+1 -1
mediawiki/extensions/SecurePollmaster+3 -3
mediawiki/extensions/LiquidThreadsmaster+1 -1
mediawiki/extensions/CentralAuthmaster+7 -7
mediawiki/coremaster+24 -24
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 872437 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Replace deprecated HTMLForm::addPreText/addHeaderText

https://gerrit.wikimedia.org/r/872437

Change 872423 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/872423

Change 872475 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LiquidThreads@master] Replace deprecated HTMLForm::setIntro

https://gerrit.wikimedia.org/r/872475

Change 872476 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Interwiki@master] Replace deprecated HTMLForm::setIntro

https://gerrit.wikimedia.org/r/872476

Change 872477 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalPreferences@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/872477

Change 872475 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Replace deprecated HTMLForm::setIntro

https://gerrit.wikimedia.org/r/872475

Change 872432 merged by jenkins-bot:

[mediawiki/extensions/TemplateSandbox@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/872432

Change 872431 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/872431

Change 872434 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Replace deprecated HTMLForm::setHeaderText

https://gerrit.wikimedia.org/r/872434

Change 872437 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Replace deprecated HTMLForm::addPreText/addHeaderText

https://gerrit.wikimedia.org/r/872437

Change 872430 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Replace deprecated HTMLForm::addPreText/addHeaderText

https://gerrit.wikimedia.org/r/872430

Change 872426 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Replace deprecated HTMLForm::addPreText/addHeaderText

https://gerrit.wikimedia.org/r/872426

Change 872477 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/872477

Change 872429 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Replace deprecated HTMLForm::setPreText

https://gerrit.wikimedia.org/r/872429

Change 872421 merged by jenkins-bot:

[mediawiki/extensions/ApiFeatureUsage@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/872421

Change 872436 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Replace deprecated HTMLForm::setPreText/setHeaderText

https://gerrit.wikimedia.org/r/872436

Change 872433 merged by jenkins-bot:

[mediawiki/extensions/ThrottleOverride@master] Replace deprecated HTMLForm::addPostText

https://gerrit.wikimedia.org/r/872433

Change 872435 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace deprecated HTMLForm::setPreText/setHeaderText

https://gerrit.wikimedia.org/r/872435

Change 872427 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/872427

Change 872476 merged by jenkins-bot:

[mediawiki/extensions/Interwiki@master] Replace deprecated HTMLForm::setIntro

https://gerrit.wikimedia.org/r/872476

Change 872422 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Replace deprecated HTMLForm::setHeaderText

https://gerrit.wikimedia.org/r/872422

Change 872424 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Replace deprecated HTMLForm::setFooterText

https://gerrit.wikimedia.org/r/872424

Change 872428 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/872428

Change 872425 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Replace deprecated HTMLForm::addFooterText

https://gerrit.wikimedia.org/r/872425

Change #1052391 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WatchSubpages@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/1052391

Change #1052392 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WatchAnalytics@master] Replace deprecated HTMLForm::setPostText

https://gerrit.wikimedia.org/r/1052392

Change #1052393 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikispeech@master] Replace deprecated HTMLForm::setPostText

https://gerrit.wikimedia.org/r/1052393

Change #1052395 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UserExport@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/1052395

Change #1052396 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Survey@master] Replace deprecated HTMLForm::setHeaderText

https://gerrit.wikimedia.org/r/1052396

Change #1052397 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/StructuredNavigation@master] Replace deprecated HTMLForm::setPostText

https://gerrit.wikimedia.org/r/1052397

Change #1052398 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/RegexBlock@master] Replace deprecated HTMLForm::setHeaderText/addHeaderText

https://gerrit.wikimedia.org/r/1052398

Change #1052399 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/QuizGame@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052399

Change #1052400 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PollNY@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052400

Change #1052401 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PictureGame@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052401

Change #1052402 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageForms@master] Replace deprecated HTMLForm::addPreText/addPostText

https://gerrit.wikimedia.org/r/1052402

Change #1052403 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FanBoxes@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052403

Change #1052404 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DeletePagesForGood@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052404

Change #1052405 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BulkBlock@master] Replace deprecated HTMLForm::setIntro

https://gerrit.wikimedia.org/r/1052405

Change #1052406 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BibManager@master] Replace deprecated HTMLForm::addPostText

https://gerrit.wikimedia.org/r/1052406

Change #1052407 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AdManager@master] Replace deprecated HTMLForm::setHeaderText

https://gerrit.wikimedia.org/r/1052407

Change #1052408 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MathSearch@master] Replace deprecated HTMLForm::setHeaderText

https://gerrit.wikimedia.org/r/1052408

Change #1052409 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] upload: Replace deprecated HTMLForm::addPreText/FooterText/HeaderText

https://gerrit.wikimedia.org/r/1052409

Change #1052409 merged by jenkins-bot:

[mediawiki/core@master] upload: Replace deprecated HTMLForm::addPreText/FooterText/HeaderText

https://gerrit.wikimedia.org/r/1052409

Change #1052404 merged by jenkins-bot:

[mediawiki/extensions/DeletePagesForGood@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052404

Change #1052406 merged by jenkins-bot:

[mediawiki/extensions/BibManager@master] Replace deprecated HTMLForm::addPostText

https://gerrit.wikimedia.org/r/1052406

Change #1052405 merged by jenkins-bot:

[mediawiki/extensions/BulkBlock@master] Replace deprecated HTMLForm::setIntro

https://gerrit.wikimedia.org/r/1052405

Change #1052393 merged by Umherirrender:

[mediawiki/extensions/Wikispeech@master] Replace deprecated HTMLForm::setPostText

https://gerrit.wikimedia.org/r/1052393

Change #1052398 merged by Umherirrender:

[mediawiki/extensions/RegexBlock@master] Replace deprecated HTMLForm::setHeaderText/addHeaderText

https://gerrit.wikimedia.org/r/1052398

Change #1052407 merged by Umherirrender:

[mediawiki/extensions/AdManager@master] Replace deprecated HTMLForm::setHeaderText

https://gerrit.wikimedia.org/r/1052407

Change #1052396 merged by Umherirrender:

[mediawiki/extensions/Survey@master] Replace deprecated HTMLForm::setHeaderText

https://gerrit.wikimedia.org/r/1052396

Change #1052408 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Replace deprecated HTMLForm::setHeaderText

https://gerrit.wikimedia.org/r/1052408

Change #1052401 merged by jenkins-bot:

[mediawiki/extensions/PictureGame@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052401

Change #1052391 merged by jenkins-bot:

[mediawiki/extensions/WatchSubpages@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/1052391

Change #1052395 merged by jenkins-bot:

[mediawiki/extensions/UserExport@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/1052395

Change #1052402 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Replace deprecated HTMLForm::addPreText/addPostText

https://gerrit.wikimedia.org/r/1052402

Change #1052392 merged by jenkins-bot:

[mediawiki/extensions/WatchAnalytics@master] Replace deprecated HTMLForm::setPostText

https://gerrit.wikimedia.org/r/1052392

Change #1052400 merged by jenkins-bot:

[mediawiki/extensions/PollNY@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052400

Change #1052399 merged by jenkins-bot:

[mediawiki/extensions/QuizGame@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052399

Change #1052397 merged by jenkins-bot:

[mediawiki/extensions/StructuredNavigation@master] Replace deprecated HTMLForm::setPostText

https://gerrit.wikimedia.org/r/1052397

Change #1052403 merged by Umherirrender:

[mediawiki/extensions/FanBoxes@master] Replace deprecated HTMLForm::addPreText

https://gerrit.wikimedia.org/r/1052403

Change #1054052 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageProperties@master] Replace deprecated HTMLForm::getHeaderHtml/getFooterHtml

https://gerrit.wikimedia.org/r/1054052

Change #1054053 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/VisualData@master] Replace deprecated HTMLForm::getHeaderText/getFooterText

https://gerrit.wikimedia.org/r/1054053

Change #1054054 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Replace deprecated HTMLForm::addPreText/addPostText

https://gerrit.wikimedia.org/r/1054054

Change #1054054 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated HTMLForm::addPreText/addPostText

https://gerrit.wikimedia.org/r/1054054

Change #1055505 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] htmlform: Hard-deprecated HTMLForm::*Text functions

https://gerrit.wikimedia.org/r/1055505

Change #1054052 merged by jenkins-bot:

[mediawiki/extensions/PageProperties@master] Replace deprecated HTMLForm::getHeaderText/getFooterText

https://gerrit.wikimedia.org/r/1054052

Change #1054053 merged by jenkins-bot:

[mediawiki/extensions/VisualData@master] Replace deprecated HTMLForm::getHeaderText/getFooterText

https://gerrit.wikimedia.org/r/1054053

Jdforrester-WMF renamed this task from Hard-deprecate HTMLForm::*Text function (and remove a release later) to Hard-deprecate HTMLForm::*Text function (and remove in MW 1.44).Jul 26 2024, 5:46 PM

Change #1055505 merged by jenkins-bot:

[mediawiki/core@master] htmlform: Hard-deprecated HTMLForm::*Text functions

https://gerrit.wikimedia.org/r/1055505

Umherirrender changed the task status from Open to Stalled.Jul 26 2024, 6:59 PM
Umherirrender removed Umherirrender as the assignee of this task.
Umherirrender edited projects, added MW-1.44-release; removed Patch-For-Review.
Umherirrender moved this task from Blocker to Deprecate or remove on the MW-1.44-release board.
Umherirrender changed the task status from Stalled to Open.Oct 22 2024, 5:55 PM

Change #1131436 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UserVerification@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/1131436

Change #1131438 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] htmlform: Hard-deprecated HTMLForm::*Text functions

https://gerrit.wikimedia.org/r/1131438

Change #1131438 merged by jenkins-bot:

[mediawiki/core@master] htmlform: Drop HTMLForm::*Text and FormSpecialPage::*Text functions, deprecated in 1.38

https://gerrit.wikimedia.org/r/1131438

Change #1131436 merged by Thomas-topway-it:

[mediawiki/extensions/UserVerification@master] Replace deprecated HTMLForm::addHeaderText

https://gerrit.wikimedia.org/r/1131436