Page MenuHomePhabricator
Create Task
Maniphest T325475

Hard-deprecate CommentStore::getStore function (and remove in 1.41)
Closed, ResolvedPublic
Actions

Description

The function CommentStore::getStore is deprecated since 1.31

The usage should be replaced and the function should be hard-deprecated and removed.

MediaWikiServices::getInstance()->getCommentStore() is usable since 1.31 and should match most extensions required version, when DI is not possible at that location.

CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbCommentStore%5Cs*%3A%3A%5Cs*getStore%5Cb&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Remove deprecated CommentStore::getStoremediawiki/coremaster+1 -16
Hard-deprecate CommentStore::getStoremediawiki/coremaster+4 -2
Use CommentStore service instead of deprecated methodmediawiki/coremaster+80 -52
Remove dead code about deprecated CommentStore::getStoremediawiki/extensions/RegexBlockmaster+1 -9
Replace deprecated CommentStore::getStoremediawiki/extensions/CentralNoticemaster+3 -3
Replace deprecated CommentStore::getStoremediawiki/extensions/ArticleFeedbackv5master+3 -3
Replace deprecated CommentStore::getStoremediawiki/extensions/OAuthmaster+1 -1
Replace deprecated CommentStore::getStoremediawiki/extensions/SocialProfilemaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Dec 18 2022, 4:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2022, 4:50 PM
gerritbot added a comment.Dec 18 2022, 4:59 PM

Change 868836 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SocialProfile@master] Replace deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868836

gerritbot added a project: Patch-For-Review.Dec 18 2022, 4:59 PM

Change 868837 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/OAuth@master] Replace deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868837

gerritbot added a comment.Dec 18 2022, 5:03 PM

Change 868838 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Replace deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868838

gerritbot added a comment.Dec 18 2022, 5:04 PM

Change 868839 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ArticleFeedbackv5@master] Replace deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868839

gerritbot added a comment.Dec 18 2022, 5:05 PM

Change 868840 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/RegexBlock@master] Remove dead code about deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868840

gerritbot added a comment.Dec 20 2022, 8:31 AM

Change 868837 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Replace deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868837

gerritbot added a comment.Dec 20 2022, 8:31 AM

Change 868836 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Replace deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868836

Umherirrender mentioned this in rESPR97c194083164: Replace deprecated CommentStore::getStore.Dec 20 2022, 8:34 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 20 2022, 9:00 AM
gerritbot added a comment.Dec 20 2022, 5:21 PM

Change 868839 merged by jenkins-bot:

[mediawiki/extensions/ArticleFeedbackv5@master] Replace deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868839

gerritbot added a comment.Dec 20 2022, 5:21 PM

Change 868838 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868838

Umherirrender moved this task from Untriaged to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.Dec 20 2022, 6:35 PM
gerritbot added a comment.Dec 22 2022, 7:11 PM

Change 868840 merged by Umherirrender:

[mediawiki/extensions/RegexBlock@master] Remove dead code about deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/868840

Maintenance_bot removed a project: Patch-For-Review.Dec 22 2022, 7:30 PM
gerritbot added a comment.Jan 2 2023, 11:53 PM

Change 811767 had a related patch set uploaded (by Umherirrender; author: Derick Alangi):

[mediawiki/core@master] Use CommentStore service instead of deprecated method

https://gerrit.wikimedia.org/r/811767

gerritbot added a project: Patch-For-Review.Jan 2 2023, 11:53 PM
gerritbot added a comment.Jan 5 2023, 12:08 AM

Change 811767 merged by jenkins-bot:

[mediawiki/core@master] Use CommentStore service instead of deprecated method

https://gerrit.wikimedia.org/r/811767

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.18; 2023-01-09); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 5 2023, 1:00 AM
gerritbot added a comment.Jan 9 2023, 5:02 PM

Change 877226 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate CommentStore::getStore

https://gerrit.wikimedia.org/r/877226

gerritbot added a comment.Jan 14 2023, 2:37 AM

Change 877226 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate CommentStore::getStore

https://gerrit.wikimedia.org/r/877226

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.19; 2023-01-16); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 14 2023, 3:00 AM
Umherirrender renamed this task from Hard-deprecate CommentStore::getStore function (and remove a release later) to Hard-deprecate CommentStore::getStore function (and remove in 1.41).Jan 14 2023, 11:54 AM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed a project: Patch-For-Review.
Umherirrender changed the task status from Stalled to Open.Mar 14 2023, 9:35 PM
gerritbot added a comment.Apr 22 2023, 6:16 PM

Change 910830 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/910830

gerritbot added a project: Patch-For-Review.Apr 22 2023, 6:16 PM
Umherirrender claimed this task.Apr 22 2023, 6:16 PM
gerritbot added a comment.Apr 24 2023, 4:23 PM

Change 910830 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated CommentStore::getStore

https://gerrit.wikimedia.org/r/910830

Maintenance_bot removed a project: Patch-For-Review.Apr 24 2023, 4:30 PM
Jdforrester-WMF closed this task as Resolved.Apr 24 2023, 7:09 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL