Description
The 8px of spacing between the ToC icon and the page title in the sticky header is missing.
current | correct |
---|---|
QA Results - Beta
AC | Status | Details |
---|---|---|
1 | ✅ | T325554#8529454 |
QA Results - Prod
AC | Status | Details |
---|---|---|
1 | ✅ | T325554#8547518 |
• alexhollender_WMF | |
Dec 19 2022, 3:00 PM |
F36421128: Screenshot 2023-01-22 at 7.50.47 PM.png | |
Jan 23 2023, 3:52 AM |
F36421127: Screenshot 2023-01-22 at 7.50.55 PM.png | |
Jan 23 2023, 3:52 AM |
F36268770: Screen Shot 2023-01-16 at 4.43.28 PM.png | |
Jan 16 2023, 10:43 PM |
F35876320: image.png | |
Dec 19 2022, 3:00 PM |
F35876315: Screen Shot 2022-12-19 at 9.59.00 AM.png | |
Dec 19 2022, 3:00 PM |
The 8px of spacing between the ToC icon and the page title in the sticky header is missing.
current | correct |
---|---|
AC | Status | Details |
---|---|---|
1 | ✅ | T325554#8529454 |
AC | Status | Details |
---|---|---|
1 | ✅ | T325554#8547518 |
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Ensure TOC in sticky header has correct margin, refactor TOC styles to be more consistent | mediawiki/skins/Vector | master | +100 -100 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | ovasileva | T317884 [EPIC] Vector 2022 post-deployment work | |||
Open | ovasileva | T317632 [EPIC] Visual refinements pt2 | |||
Resolved | ovasileva | T325554 [Regression] ToC icon in sticky header is missing spacing |
Oh I didnt know this ticket existed, I actually fixed this as part of T324877. I separated out those changes to https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/877243
Change 876252 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Page tools styling followup
Change 877243 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Ensure TOC in sticky header has correct margin, refactor TOC styles to be more consistent
Change 877243 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Ensure TOC in sticky header has correct margin, refactor TOC styles to be more consistent
Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: The 8px of spacing between the ToC icon and the page title in the sticky header is missing.