Page MenuHomePhabricator

[Regression] ToC icon in sticky header is missing spacing
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

The 8px of spacing between the ToC icon and the page title in the sticky header is missing.

currentcorrect
Screen Shot 2022-12-19 at 9.59.00 AM.png (1×2 px, 215 KB)
image.png (1×2 px, 201 KB)

QA Results - Beta

ACStatusDetails
1T325554#8529454

QA Results - Prod

ACStatusDetails
1T325554#8547518

Event Timeline

ovasileva renamed this task from [Bug] ToC icon in sticky header is missing spacing to [Regression] ToC icon in sticky header is missing spacing.Dec 20 2022, 7:55 PM
ovasileva triaged this task as High priority.

Oh I didnt know this ticket existed, I actually fixed this as part of T324877. I separated out those changes to https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/877243

Change 876252 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Page tools styling followup

https://gerrit.wikimedia.org/r/876252

Change 877243 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure TOC in sticky header has correct margin, refactor TOC styles to be more consistent

https://gerrit.wikimedia.org/r/877243

ovasileva set the point value for this task to 2.
ovasileva lowered the priority of this task from High to Medium.Jan 11 2023, 5:43 PM

Change 877243 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure TOC in sticky header has correct margin, refactor TOC styles to be more consistent

https://gerrit.wikimedia.org/r/877243

bwang moved this task from Code Review to QA on the Web-Team FY2022-23 Q3 Sprint 1 board.
bwang added a subscriber: Jdrewniak.

Looks good on the beta cluster, moving to QA in prod

Screen Shot 2023-01-16 at 4.43.28 PM.png (338×990 px, 178 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The 8px of spacing between the ToC icon and the page title in the sticky header is missing.

Screenshot 2023-01-22 at 7.50.55 PM.png (188×274 px, 10 KB)

Screenshot 2023-01-22 at 7.50.47 PM.png (173×468 px, 25 KB)