Page MenuHomePhabricator

Determine how to fix instrumentation for Search Preview on mobile
Closed, ResolvedPublic

Description

For Search Preview instrumentation (see T321069), we want to track sessions, but search session id is not available on mobile. This is because search_satisfaction is not activated on mobile web.

From @dcausse:

Checked the code and it's explicitly disabled on minerva (the skin used for mobile web). Simply enabling it might not be entirely possible as it was probably done this way for some reasons that unfortunately I don't know/remember, we might want to file a task to re-assess this and make it work, unfortunately I don't know enough this part of the code to know if it'll work out of the box or if there will be adaptions to make. The oldest reference of the search satisfaction instrumentation being ignored on mobile is from 2015 (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/248087) the sole context I could infer relates to performance but mobile is not explicitly called out so unsure if this was the sole reason or simply because we did not care about mobile at the time. This code has changed a lot since this patch and I won't be surprised that it'd require some adaptions to work on mobile web.

From @matthiasmullie:

SearchVue is (just about) good to go and will capture all the information in the instrumentation document on desktop. Some of the things in there, however, are related to searchSatisfaction, which isn’t available on mobile (there is other, different, instrumentation on mobile). We’re good to go with desktop but will not have all info on mobile (for the things that require searchSatisfaction)....we’re going to have to figure out solutions. Do we make searchSatisfaction work on mobile? How (there’s probably a reason it’s not there)? Do we need another schema? Or should we instrument the missing bits within SearchVue’s schema to work around the lack of searchSatisfaction? Etc. Those may also affect what’s being captured on desktop (e.g. tracking more/different things directly instead of using searchSatisfaction data).

Acceptance Criteria:

Event Timeline

Assigning to Matthias to complete the next steps discussed in today's meeting:

Create a phab ticket that includes the following:

  • Connie to confirm which data we need session ID or other search satisfaction elements for
  • Simone to figure out how to include that data into the SearchVue schema (e.g, arbitrary new session ID); make sure we modify mobile and desktop
matthiasmullie updated the task description. (Show Details)