Page MenuHomePhabricator
Create Task
Maniphest T325585

1.40.0-wmf.22 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
dancy
Release Version
1.40.0-wmf.22
Release Date
Feb 6 2023, 12:00 AM

2023 week 06 1.40-wmf.22 Changes wmf/1.40.0-wmf.22

This MediaWiki Train Deployment is scheduled for the week of Monday, February 6th:

Monday February 6thTuesday, February 7thWednesday, February 8thThursday, February 9thFriday
Backports only.Branch wmf.22 and deploy to Group 0 Wikis.Deploy wmf.22 to Group 1 Wikis.Deploy wmf.22 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.22 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.40.0-wmf.21
Next: 1.40.0-wmf.23
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
group2 wikis to 1.40.0-wmf.22operations/mediawiki-configmaster+325 -325
group1 wikis to 1.40.0-wmf.22operations/mediawiki-configmaster+540 -540
group1 wikis to 1.40.0-wmf.21operations/mediawiki-configmaster+540 -540
group1 wikis to 1.40.0-wmf.22operations/mediawiki-configmaster+540 -540
group0 wikis to 1.40.0-wmf.22operations/mediawiki-configmaster+128 -128
testwikis wikis to 1.40.0-wmf.22operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.40.0-wmf.22mediawiki/corewmf/1.40.0-wmf.22+991 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Dec 19 2022, 7:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2022, 7:47 PM
thcipriani assigned this task to • demon.Dec 19 2022, 8:02 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: dancy.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
• demon closed this task as Resolved.Jan 3 2023, 12:16 AM
• demon reopened this task as Open.
kostajh added a subtask: T328676: Special:Preferences throws internal error on beta due to null defaults in Echo.Feb 2 2023, 5:06 PM
matmarex closed subtask T328676: Special:Preferences throws internal error on beta due to null defaults in Echo as Resolved.Feb 2 2023, 5:43 PM
Jdlrobson added subscribers: Jdlrobson, Catrope.Feb 2 2023, 9:58 PM
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/885788 (T127268)
  • Summary:
    • Code that previously would only run on the desktop site now runs on the mobile site. Great care has been taken to gradually make this move, but there is a chance given the size of our ecosystem that some JavaScript sneaks into our mobile site that results in some kind of functional regression or JavaScript error
  • Test plan:
    • I'll be monitoring logstash during the rollout to identify issues before community members do, but there is a possibility of bugs filed against the mobile site.
  • Places to monitor:
  • Revert plan:
    • Reverting the core patch (and follow ups) is an option, but I'd rather avoid that. It will be quicker and less disruptive, to disable broken experiences if and where they occur. If we run into these issues, the code in question can be updated by modifying the ResourceLoader definition to explicitly set targets desktop. Holding the train is preferred in the unlikely situation the bug meets the definition set in https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Issues_that_hold_the_train

See wikitech-l for more details on the issue and how to remedy any problems we see.

  • Affected wikis:

All

  • IRC contact: @Jdlrobson @Catrope (UTC+8)
  • UBN Task Projects/tags: T127268
  • Would you like to backport this change rather than ride the train?: No
gerritbot added a comment.Feb 7 2023, 3:07 AM

Change 886849 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.40.0-wmf.22] Branch commit for wmf/1.40.0-wmf.22

https://gerrit.wikimedia.org/r/886849

gerritbot added a project: Patch-For-Review.Feb 7 2023, 3:07 AM
gerritbot added a comment.Feb 7 2023, 3:22 AM

Change 886849 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.22] Branch commit for wmf/1.40.0-wmf.22

https://gerrit.wikimedia.org/r/886849

gerritbot added a comment.Feb 7 2023, 4:01 AM

Change 887001 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/887001

gerritbot added a comment.Feb 7 2023, 4:02 AM

Change 887001 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/887001

Stashbot added a comment.Feb 7 2023, 4:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T04:02:37Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.40.0-wmf.22 refs T325585

Stashbot added a comment.Feb 7 2023, 4:55 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T04:55:48Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.40.0-wmf.22 refs T325585 (duration: 53m 11s)

gerritbot added a comment.Feb 7 2023, 7:47 PM

Change 887393 had a related patch set uploaded (by TrainBranchBot; author: Chad Horohoe):

[operations/mediawiki-config@master] group0 wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/887393

gerritbot added a comment.Feb 7 2023, 7:47 PM

Change 887393 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/887393

Stashbot added a comment.Feb 7 2023, 7:55 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T19:55:16Z] <demon@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.40.0-wmf.22 refs T325585

gerritbot added a comment.Feb 8 2023, 8:02 PM

Change 887824 had a related patch set uploaded (by TrainBranchBot; author: Chad Horohoe):

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/887824

gerritbot added a comment.Feb 8 2023, 8:03 PM

Change 887824 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/887824

Stashbot added a comment.Feb 8 2023, 8:11 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T20:11:11Z] <demon@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.40.0-wmf.22 refs T325585

Stashbot added a comment.Feb 8 2023, 8:17 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T20:17:44Z] <demon@deploy1002> Synchronized php: group1 wikis to 1.40.0-wmf.22 refs T325585 (duration: 06m 33s)

• Zabe added a subtask: T329233: Wikibase\Repo\RestApi\Domain\Services\ItemUpdateFailed: <Error, collected 1 message(s) on the way, array value set>+----------+---------------------------+--------------------------------------+| error | actionthrottledtex.Feb 8 2023, 8:55 PM
gerritbot added a comment.Feb 8 2023, 10:15 PM

Change 887840 had a related patch set uploaded (by TrainBranchBot; author: Chad Horohoe):

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.21

https://gerrit.wikimedia.org/r/887840

gerritbot added a comment.Feb 8 2023, 10:15 PM

Change 887840 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.21

https://gerrit.wikimedia.org/r/887840

Stashbot added a comment.Feb 8 2023, 10:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T22:23:14Z] <demon@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.40.0-wmf.21 refs T325585

Stashbot added a comment.Feb 8 2023, 10:29 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-08T22:29:44Z] <demon@deploy1002> Synchronized php: group1 wikis to 1.40.0-wmf.21 refs T325585 (duration: 06m 29s)

dancy subscribed.Feb 8 2023, 11:07 PM
gerritbot added a comment.Feb 10 2023, 7:25 PM

Change 888247 had a related patch set uploaded (by TrainBranchBot; author: Chad Horohoe):

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/888247

gerritbot added a comment.Feb 10 2023, 7:26 PM

Change 888247 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/888247

Stashbot added a comment.Feb 10 2023, 7:33 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-10T19:33:15Z] <demon@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.40.0-wmf.22 refs T325585

Stashbot added a comment.Feb 10 2023, 7:39 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-10T19:39:50Z] <demon@deploy1002> Synchronized php: group1 wikis to 1.40.0-wmf.22 refs T325585 (duration: 06m 34s)

gerritbot added a comment.Feb 10 2023, 10:17 PM

Change 888272 had a related patch set uploaded (by TrainBranchBot; author: Chad Horohoe):

[operations/mediawiki-config@master] group2 wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/888272

gerritbot added a comment.Feb 10 2023, 10:18 PM

Change 888272 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.40.0-wmf.22

https://gerrit.wikimedia.org/r/888272

Stashbot added a comment.Feb 10 2023, 10:25 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-10T22:25:44Z] <demon@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.40.0-wmf.22 refs T325585

• demon closed this task as Resolved.Feb 12 2023, 12:05 AM

One subtask is still open, but closing this as the train was able to move forward with a partial fix.

WMDE-leszek closed subtask T329233: Wikibase\Repo\RestApi\Domain\Services\ItemUpdateFailed: <Error, collected 1 message(s) on the way, array value set>+----------+---------------------------+--------------------------------------+| error | actionthrottledtex as Resolved.Feb 16 2023, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits