Maniphest T325610

Check if setBigSelects() is still needed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aaron
	Dec 20 2022, 12:55 AM

Tags

Referenced Files

None

Subscribers

Description

The only setBigSelects() caller is in LogPager, dating to 2009 in 18244534612a.

Would be nice to remove if this not needed anymore. MariaDB has improved query planning and we are better at making sure indexes statistics are updated (e.g. OPTIMIZE).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	rdbms: remove unused "defaultBigSelects" field from DatabaseMysqlBase	mediawiki/core	master	+0 -2
	rdbms: Remove setBigSelects() without deprecation	mediawiki/core	master	+1 -53

Customize query in gerrit

Related Objects

Mentioned Here: rMW18244534612a: (bug 18657) Workaround for MySQL optimiser bug. Replaces Domas's live patch.

Event Timeline

aaron created this task.Dec 20 2022, 12:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2022, 12:55 AM

aaron added a project: SRE.Jan 5 2023, 7:58 AM

• larissagaulia moved this task from Inbox, needs triage to Radar on the Performance-Team board.Jan 5 2023, 7:58 AM

• larissagaulia edited projects, added Performance-Team (Radar); removed Performance-Team.

aaron triaged this task as Lowest priority.Jan 5 2023, 8:00 AM

aaron updated the task description. (Show Details)Jan 5 2023, 10:12 PM

Change 876021 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: deprecate setBigSelects()

https://gerrit.wikimedia.org/r/876021

gerritbot added a project: Patch-For-Review.Jan 5 2023, 10:14 PM

LSobanski added a project: DBA.Jan 6 2023, 1:19 PM

LSobanski added a subscriber: Ladsgroup.

Change 876021 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Remove setBigSelects() without deprecation

https://gerrit.wikimedia.org/r/876021

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2023, 12:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 7 2023, 1:00 AM

Ladsgroup closed this task as Resolved.Jan 7 2023, 6:54 PM

Ladsgroup assigned this task to Krinkle.

Change 914888 had a related patch set uploaded (by Krinkle; author: Aaron Schulz):

[mediawiki/core@master] rdbms: remove unused "defaultBigSelects" field from DatabaseMysqlBase

https://gerrit.wikimedia.org/r/914888

gerritbot added a project: Patch-For-Review.May 4 2023, 6:30 PM

Change 914888 merged by jenkins-bot:

[mediawiki/core@master] rdbms: remove unused "defaultBigSelects" field from DatabaseMysqlBase

https://gerrit.wikimedia.org/r/914888

Maintenance_bot removed a project: Patch-For-Review.May 4 2023, 7:10 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 10:01 AM