Page MenuHomePhabricator

[SWIFT_STORAGE] put exception: AttributeError("'ClientException' object has no attribute 'startswith'",) for files in office wiki
Closed, ResolvedPublicPRODUCTION ERROR

Description

I was searching through thumbor logs in logstash and noticed that this is the most common error. It seems specific to files in office wiki.
The python swift client throws an Exception, and we catch it and write it to the logs.

The questions is why is that erroring (I'm assuming officewiki has different permissions, though I'm not sure how they have thumbnails then), which is causing it to not access an attribute on a swift action.

Are these requests even supposed to end up here ?
Should we make office wiki some sort of special exception in our thumbor client ?

Error
normalized_message
[SWIFT_STORAGE] put exception: AttributeError("'ClientException' object has no attribute 'startswith'",)

by /usr/lib/python2.7/dist-packages/wikimedia_thumbor/result_storage/swift/swift.py

Impact

None other than thousands and thousands of log lines.

Notes

Event Timeline

@TheDJ hello.
Thank you for the really good catch.
Does it happen on the current production version of Thumbor?

Yes this is on current production of thumbor.

A look at the logs make it seem like this issue isn't happening any more.