Page MenuHomePhabricator

Make sure all callers to functions that require __METHOD__ parameter pass it
Open, MediumPublic

Description

Usually it's made optional, and is never in the same place, os it can be quite annoying..

More than once have bugs been found from wrong parameter orders, such as passing another parameter for the function name.

It's also just good practise, for profiling etc etc

Not sure if there is much that can be done to automagically scan the code for them...


Version: unspecified
Severity: normal

Details

Reference
bz30575

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:54 PM
bzimport set Reference to bz30575.
bzimport added a subscriber: Unknown Object (MLST).
Reedy created this task.Aug 25 2011, 10:12 PM
demon added a comment.Aug 27 2011, 2:42 PM

Just to clarify (I had to re-read this, the summary wasn't quite clear)...we're talking about functions like DB functions where we pass METHOD and such.

Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).