Page MenuHomePhabricator

Do not show aliases in ZObjectSelector for now
Closed, ResolvedPublic

Description

Currently, when we select a type e.g. as the input or output type in the Function editor, and the search string matches against an alias, we show two lines, the first line with the label of the type, the second line with the alias it matches against.

It is slightly confusing to not show why a search result matches, but the current styling is even more confusing.

As a stop gap this task suggests to remove the line with the alias.

The full implementation about changing the styling is here: T323930

This task can be skipped and closed if instead the solution in T323930 is implemented.

Event Timeline

Change 871325 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Remove alias labels from ZObjectLabels search. Once FE styling is implemented they should be added back in.

https://gerrit.wikimedia.org/r/871325

Change 871325 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove alias labels from ZObjectLabels search. Once FE styling is implemented they should be added back in.

https://gerrit.wikimedia.org/r/871325

Argh, this is a revert of a patch we made a week before this. :-( "Slightly confusing" is better than the new behaviour, when alias hits just disappear.