As reported by Dom:
And Volker suggested making the text attribute required:
Open questions:
Acceptance criteria:
I feel like making text mandatory was discussed at the last check-in in relation to T322787: IPA can be optional only if a wikidata item or audio file is provided (cc @MusikAnimal)
I don't think we need to necessarily make it mandatory, if that'd only be to give aria-label something to display. We could just re-phrase it a bit when there's no text, e.g. "Listen to the IPA pronunciation of this word or phrase."
But if it's like alt text, then maybe it's good to always have a text label of what the audio is for?
Change 886315 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/Phonos@master] Move aria-label to be on anchor, and remove `text` from it
Change 886315 merged by jenkins-bot:
[mediawiki/extensions/Phonos@master] Move aria-label to be on anchor, and remove `text` from it
As a screen reader user, I'd prefer "Listen to pronunciation" ... or something; much snappier.
Change 890948 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/Phonos@master] Shorten aria-label for PhonosButtons
@Graham87 What about the case when you have multiple IPA pronunciations on a page, for example for Australian vs. British English? Are people going to be able to distinguish them?
@Nardog I think your suggestion of "Play audio" is good.
Is it worth making the label customizable? So that more specific details could be provided when required? e.g.
<phonos file="intro.mp3" aria-label="Listen to the opening bars of the piece" />
Is it worth making the label customizable? So that more specific details could be provided when required? e.g.
<phonos file="intro.mp3" aria-label="Listen to the opening bars of the piece" />
I doubt it given what @Graham87 said above. If it is not obvious what the audio is about without the label, then it's probably not obvious to sighted readers either. It couldn't hurt to make it customizable, but it might accidentally invite overexplanation that doesn't actually help screenreader users. Obviously deferring to Graham (or anyone else using screenreaders or with experience in accessibility development) though.
Change 890948 merged by jenkins-bot:
[mediawiki/extensions/Phonos@master] Shorten aria-label for PhonosButtons
The aria-label is now "Play audio" (with some exceptions noted in T330851).
@Graham87 just checking you are OK with the change of wording.
If a file is passed to Phonos we don't know whether it is a recording of a pronunciation or not. However, if ipa and text are passed without a file we can be pretty sure it is meant to be a pronunciation. Perhaps we could show different aria-labels based on this condition.
Sure, sounds good.
If a file is passed to Phonos we don't know whether it is a recording of a pronunciation or not. However, if ipa and text are passed without a file we can be pretty sure it is meant to be a pronunciation. Perhaps we could show different aria-labels based on this condition.
No need, I don't think
; "Play audio" works everywhere.