Page MenuHomePhabricator
Create Task
Maniphest T325974

Replace and hard-deprecate Language::isSupportedLanguage/isValidCode/isValidBuiltInCode/isKnownLanguageTag (and remove in 1.41)
Closed, ResolvedPublic
Actions

Description

The functions

  • Language::isSupportedLanguage
  • Language::isValidCode
  • Language::isValidBuiltInCode
  • Language::isKnownLanguageTag

are deprecated. The usage should be replaced, the function hard-deprecated and removed

CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbLanguage%5Cs*%3A%3A%5Cs*(isSupportedLanguage%7CisValidCode%7CisValidBuiltInCode%7CisKnownLanguageTag)%5Cb&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Language: Remove deprecated functions and constantsmediawiki/coremaster+60 -679
Hard-deprecate Language::isSupportedLanguage/isValid(BuiltIn)Codemediawiki/coremaster+17 -5
Replace deprecated Language::isKnownLanguageTagmediawiki/extensions/Hreflangmaster+15 -1
Replace deprecated Language::isValidCodemediawiki/extensions/CommonMessagesmaster+15 -1
Replace deprecated Language::isValidCodemediawiki/extensions/NewsBoxmaster+2 -2
Replace deprecated Language::fetchLanguageName/isValidBuiltInCodemediawiki/extensions/TranslateSvgmaster+16 -9
Replace deprecated Language::isKnownLanguageTagmediawiki/extensions/TwnMainPagemaster+3 -1
Replace deprecated Language::isKnownLanguageTagmediawiki/extensions/Translatemaster+5 -4
Replace deprecated Language::isValidCode/isValidBuiltInCodemediawiki/extensions/Wikibasemaster+7 -5
Replace deprecated Language::isValidBuiltInCodemediawiki/extensions/DonationInterfacemaster+2 -2
Replace deprecated Language::isKnownLanguageTag/isValidBuiltInCodemediawiki/extensions/ContentTranslationmaster+69 -25
Replace deprecated Language::isValidCodemediawiki/extensions/CentralNoticemaster+26 -2
Replace deprecated Language::isSupportedLanguagemediawiki/extensions/EntitySchemamaster+21 -9
Replace deprecated Language::isValidCode/isSupportedLanguagemediawiki/extensions/LandingCheckmaster+20 -5
Replace deprecated Language::isValidCodemediawiki/extensions/ReadingListsmaster+21 -6
Replace deprecated Language::isValidCode/isValidBuiltInCodemediawiki/extensions/JsonConfigmaster+6 -5
Replace deprecated Language::isValidCode/isSupportedLanguagemediawiki/extensions/Scribuntomaster+10 -8
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Dec 28 2022, 1:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 28 2022, 1:15 PM
gerritbot added a comment.Dec 28 2022, 1:15 PM

Change 872954 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Replace deprecated Language::isValidCode

https://gerrit.wikimedia.org/r/872954

gerritbot added a project: Patch-For-Review.Dec 28 2022, 1:15 PM

Change 872955 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTranslation@master] Replace deprecated Language::isKnownLanguageTag/isValidBuiltInCode

https://gerrit.wikimedia.org/r/872955

gerritbot added a comment.Dec 28 2022, 1:16 PM

Change 872956 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DonationInterface@master] Replace deprecated Language::isValidBuiltInCode

https://gerrit.wikimedia.org/r/872956

gerritbot added a comment.Dec 28 2022, 1:16 PM

Change 872958 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/EntitySchema@master] Replace deprecated Language::isSupportedLanguage

https://gerrit.wikimedia.org/r/872958

gerritbot added a comment.Dec 28 2022, 1:16 PM

Change 872959 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/JsonConfig@master] Replace deprecated Language::isValidCode/isValidBuiltInCode

https://gerrit.wikimedia.org/r/872959

gerritbot added a comment.Dec 28 2022, 1:16 PM

Change 872960 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LandingCheck@master] Replace deprecated Language::isValidCode/isSupportedLanguage

https://gerrit.wikimedia.org/r/872960

gerritbot added a comment.Dec 28 2022, 1:17 PM

Change 872961 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ReadingLists@master] Replace deprecated Language::isValidCode

https://gerrit.wikimedia.org/r/872961

gerritbot added a comment.Dec 28 2022, 1:17 PM

Change 872962 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Scribunto@master] Replace deprecated Language::isValidCode/isSupportedLanguage

https://gerrit.wikimedia.org/r/872962

gerritbot added a comment.Dec 28 2022, 1:17 PM

Change 872963 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] Replace deprecated Language::isKnownLanguageTag

https://gerrit.wikimedia.org/r/872963

gerritbot added a comment.Dec 28 2022, 1:24 PM

Change 872986 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Replace deprecated Language::isValidCode/isValidBuiltInCode

https://gerrit.wikimedia.org/r/872986

Umherirrender moved this task from Untriaged to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.Dec 28 2022, 4:02 PM
gerritbot added a comment.Dec 29 2022, 2:33 AM

Change 872962 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace deprecated Language::isValidCode/isSupportedLanguage

https://gerrit.wikimedia.org/r/872962

gerritbot added a comment.Dec 29 2022, 2:34 AM

Change 872959 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Replace deprecated Language::isValidCode/isValidBuiltInCode

https://gerrit.wikimedia.org/r/872959

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 29 2022, 3:00 AM
gerritbot added a comment.Dec 29 2022, 5:28 PM

Change 872960 merged by jenkins-bot:

[mediawiki/extensions/LandingCheck@master] Replace deprecated Language::isValidCode/isSupportedLanguage

https://gerrit.wikimedia.org/r/872960

gerritbot added a comment.Dec 29 2022, 5:30 PM

Change 872961 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Replace deprecated Language::isValidCode

https://gerrit.wikimedia.org/r/872961

gerritbot added a comment.Dec 29 2022, 5:46 PM

Change 872954 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace deprecated Language::isValidCode

https://gerrit.wikimedia.org/r/872954

gerritbot added a comment.Dec 29 2022, 5:46 PM

Change 872958 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Replace deprecated Language::isSupportedLanguage

https://gerrit.wikimedia.org/r/872958

gerritbot added a comment.Dec 29 2022, 5:51 PM

Change 872955 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Replace deprecated Language::isKnownLanguageTag/isValidBuiltInCode

https://gerrit.wikimedia.org/r/872955

gerritbot added a comment.Dec 29 2022, 6:05 PM

Change 872956 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Replace deprecated Language::isValidBuiltInCode

https://gerrit.wikimedia.org/r/872956

gerritbot added a comment.Dec 29 2022, 6:08 PM

Change 872963 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace deprecated Language::isKnownLanguageTag

https://gerrit.wikimedia.org/r/872963

gerritbot added a comment.Dec 29 2022, 6:08 PM

Change 872986 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace deprecated Language::isValidCode/isValidBuiltInCode

https://gerrit.wikimedia.org/r/872986

gerritbot added a comment.Dec 29 2022, 11:16 PM

Change 873774 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CommonMessages@master] Replace deprecated Language::isValidCode

https://gerrit.wikimedia.org/r/873774

gerritbot added a comment.Dec 29 2022, 11:24 PM

Change 873778 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Hreflang@master] Replace deprecated Language::isKnownLanguageTag

https://gerrit.wikimedia.org/r/873778

gerritbot added a comment.Dec 29 2022, 11:38 PM

Change 873784 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/NewsBox@master] Replace deprecated Language::isValidCode

https://gerrit.wikimedia.org/r/873784

gerritbot added a comment.Dec 29 2022, 11:57 PM

Change 873792 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TwnMainPage@master] Replace deprecated Language::isKnownLanguageTag

https://gerrit.wikimedia.org/r/873792

gerritbot added a comment.Dec 30 2022, 12:10 AM

Change 873795 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TranslateSvg@master] Replace deprecated Language::fetchLanguageName/isValidBuiltInCode

https://gerrit.wikimedia.org/r/873795

Umherirrender added a comment.Dec 30 2022, 12:33 AM

https://github.com/SemanticMediaWiki/SemanticInterlanguageLinks/issues/97
https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/5381

gerritbot added a comment.Jan 2 2023, 5:30 AM

Change 873792 merged by jenkins-bot:

[mediawiki/extensions/TwnMainPage@master] Replace deprecated Language::isKnownLanguageTag

https://gerrit.wikimedia.org/r/873792

gerritbot added a comment.Jan 3 2023, 8:54 PM

Change 873795 merged by jenkins-bot:

[mediawiki/extensions/TranslateSvg@master] Replace deprecated Language::fetchLanguageName/isValidBuiltInCode

https://gerrit.wikimedia.org/r/873795

gerritbot added a comment.Jan 3 2023, 8:54 PM

Change 873784 merged by jenkins-bot:

[mediawiki/extensions/NewsBox@master] Replace deprecated Language::isValidCode

https://gerrit.wikimedia.org/r/873784

gerritbot added a comment.Jan 3 2023, 8:54 PM

Change 873774 merged by jenkins-bot:

[mediawiki/extensions/CommonMessages@master] Replace deprecated Language::isValidCode

https://gerrit.wikimedia.org/r/873774

gerritbot added a comment.Jan 3 2023, 8:54 PM

Change 873778 merged by jenkins-bot:

[mediawiki/extensions/Hreflang@master] Replace deprecated Language::isKnownLanguageTag

https://gerrit.wikimedia.org/r/873778

Umherirrender mentioned this in rENBX0029eb3361e1: Replace deprecated Language::isValidCode.Jan 3 2023, 9:46 PM
Umherirrender renamed this task from Replace and hard-deprecate Language::isSupportedLanguage/isWellFormedLanguageTag/isValidCode/isValidBuiltInCode/isKnownLanguageTag (and remove a release later) to Replace and hard-deprecate Language::isSupportedLanguage/isValidCode/isValidBuiltInCode/isKnownLanguageTag (and remove a release later).Jan 28 2023, 5:06 PM
gerritbot added a comment.Jan 28 2023, 5:12 PM

Change 884423 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate Language::isSupportedLanguage/isValid(BuiltIn)Code

https://gerrit.wikimedia.org/r/884423

gerritbot added a comment.Jan 30 2023, 3:58 AM

Change 884423 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate Language::isSupportedLanguage/isValid(BuiltIn)Code

https://gerrit.wikimedia.org/r/884423

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.21; 2023-01-30); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 30 2023, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 30 2023, 4:30 AM
Umherirrender renamed this task from Replace and hard-deprecate Language::isSupportedLanguage/isValidCode/isValidBuiltInCode/isKnownLanguageTag (and remove a release later) to Replace and hard-deprecate Language::isSupportedLanguage/isValidCode/isValidBuiltInCode/isKnownLanguageTag (and remove in 1.41).Jan 30 2023, 5:34 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender changed the task status from Stalled to Open.Mar 14 2023, 9:35 PM
gerritbot added a comment.Aug 1 2023, 6:35 AM

Change 936685 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Language: Remove deprecated functions and constants

https://gerrit.wikimedia.org/r/936685

gerritbot added a project: Patch-For-Review.Aug 1 2023, 6:35 AM
gerritbot added a comment.Aug 5 2023, 11:33 PM

Change 936685 merged by jenkins-bot:

[mediawiki/core@master] Language: Remove deprecated functions and constants

https://gerrit.wikimedia.org/r/936685

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2023, 12:12 AM
Umherirrender closed this task as Resolved.Aug 7 2023, 11:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits