Page MenuHomePhabricator

Interwiki extension's "URL" field doesn't validate input
Closed, ResolvedPublic

Description

The Interwiki extension's "URL" field doesn't check against the list of $wgUrlProtocols when URLs are added or edited. It should validate input.


Version: unspecified
Severity: normal

Details

Reference
bz30600

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:56 PM
bzimport set Reference to bz30600.

What if you wish to disallow gopher links, while keeping the possibility to link to a specific domain via gopher ?
Same goes with other protocols, obviously…

(In reply to comment #1)

What if you wish to disallow gopher links, while keeping the possibility to
link to a specific domain via gopher ?

Then you're being rather silly, in my opinion.

raphael.droz wrote:

fixes the regression about interwiki name not displayed in the edit-form

The previous patch brought in a regression, the interwiki prefix is not displayed anymore in the "edit" form.
The attached patch attempt to fix this by introducing $prefixElement in the "edit" code path too.

Attached:

Thanks a lot for the patch! I submitted it for review in Gerrit: https://gerrit.wikimedia.org/r/#/c/23782/ .