Page MenuHomePhabricator

Wikidata Query Builder is broken in RTL languages
Closed, ResolvedPublic

Description

Steps to replicate the issue (include links if applicable)

What happens?
The RTL (right to left) text is oriented for LTR (left to right) languages, which causes user interface sentences to be shown incorrectly.

What should have happened instead?
When the user interface language is an RTL (right to left) language, the user interface must be properly oriented for RTL.

Since the Query Builder is a rather technical tool, which includes a lot of code snippets that must be LTR, RTL direction should be applied only on the parts that show user interface sentences, and explicitly LTR everywhere else.

It seems that the css logical properties are not being applied properly, probably due to the direction not being set.

Screenshots
How it currently looks:

image.png (990×1 px, 101 KB)

Example
How it should look when it is fixed:

image.png (771×1 px, 103 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher subscribed.

Assigning to Arian for ticket prep.

It appears that the transpiled CSS logical properties (from WiKit) are not being applied properly, probably due to the direction not being set on some parent element

I think we already fixed this in Iaf7c4a5f94, but the fix hasn’t been deployed yet.

Yeah, that was broken by removing the <bdi dir="auto" id="directionSample"> element in Add header logo image to Query Builder (I4449173b) and fixed in Fix RTL support (Iaf7c4a5f). As Lucas said, it just needs to be deployed, which will happen shortly.

I wasn't aware of this task here, and noticed the broken RTL only when working on proofs of concept for T324653: investigate language switching in the UI for our single page applications.

Arian_Bozorg claimed this task.
Arian_Bozorg subscribed.

Thanks so much everyone, this looks like it's all been resolved now :)