Page MenuHomePhabricator
Create Task
Maniphest T326169

VisualEditor failing to load on interwiki redirect pages
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  1. https://www.mediawiki.org/wiki/Performance_profiling_for_Wikimedia_code?veaction=edit

What happens?:

Page is stuck indefinitely loading.

cap.png (2,348×1,498 px, 624 KB)

Uncaught TypeError: linkData is null
  toDataElement @injectedScript
  createDataElements https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.core,mwtransclusion&skin=vector&version=1s8p8:251
  getDataFromDomSubtree https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.core,mwtransclusion&skin=vector&version=1s8p8:257
  getModelFromDom https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.core,mwtransclusion&skin=vector&version=1s8p8:252
  createModelFromDom @injectedScript
  createModelFromDom @injectedScript
  setupSurface

Other information (browser name/version, screenshots, etc.):

Firefox. macOS. Is affecting other redirect pages on mediawik.org as well, but only interwiki ones it seems. For example:

And several others.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix exception editing cross-wiki redirectsBartosz Dziewońskimediawiki/extensions/VisualEditorREL1_41+3 -1
Fix exception editing cross-wiki redirectsBartosz Dziewońskimediawiki/extensions/VisualEditorREL1_42+3 -1
Fix exception editing cross-wiki redirectsMqudsimediawiki/extensions/VisualEditormaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jan 3 2023, 7:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2023, 7:49 PM
Krinkle mentioned this in T326172: VE noscript fallback link on action=edit is inaccessible.Jan 3 2023, 8:00 PM
• matmarex subscribed.Jan 3 2023, 9:11 PM

I don't think we've ever supported editing cross-wiki redirects (or realized that the feature exists).

mqudsi subscribed.Nov 27 2023, 8:34 PM

The following VisualEditor patch appears to be sufficient to stop the visual editor from breaking, without any other cascading failure that I can see from a quick test:

diff --git a/modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js b/modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js
index 3d5d1a8bb..231f00c0a 100644
--- a/modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js
+++ b/modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js
@@ -35,7 +35,7 @@ ve.dm.MWRedirectMetaItem.static.matchRdfaTypes = [ 'mw:PageProp/redirect' ];
 ve.dm.MWRedirectMetaItem.static.toDataElement = function ( domElements, converter ) {
        // HACK piggy-back on MWInternalLinkAnnotation's ./ stripping logic
        var linkData = ve.dm.MWInternalLinkAnnotation.static.toDataElement( domElements, converter );
-       linkData.type = this.name;
+       if (linkData) linkData.type = this.name;
        return linkData;
 };

Of course, in addition to this we'd probably want to patch MW itself to hide the visual edit option and default to edit source, because all you get is an empty visual editor.

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Nov 30 2023, 4:57 PM
ppelberg removed a project: Editing-team.
mqudsi added a comment.Aug 27 2024, 3:01 AM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1065918

gerritbot added a comment.Aug 27 2024, 3:56 PM

Change #1065918 had a related patch set uploaded (by Pppery; author: Mqudsi):

[mediawiki/extensions/VisualEditor@master] Fix exception editing cross-wiki redirects

https://gerrit.wikimedia.org/r/1065918

gerritbot added a project: Patch-For-Review.Aug 27 2024, 3:56 PM
gerritbot added a comment.Aug 29 2024, 10:54 PM

Change #1065918 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix exception editing cross-wiki redirects

https://gerrit.wikimedia.org/r/1065918

• matmarex closed this task as Resolved.Aug 29 2024, 10:58 PM
• matmarex assigned this task to mqudsi.

Thanks for the patch @mqudsi! This indeed allows the editor to load and function, so I think this can be considered resolved, even though the redirect target is not editable.

Proper editing support for cross-wiki redirects will probably have to wait for T322340: Support editing interwiki links within the visual editor (not sure if that will ever happen).

gerritbot added a comment.Aug 29 2024, 11:00 PM

Change #1068881 had a related patch set uploaded (by Bartosz Dziewoński; author: Mqudsi):

[mediawiki/extensions/VisualEditor@REL1_41] Fix exception editing cross-wiki redirects

https://gerrit.wikimedia.org/r/1068881

gerritbot added a comment.Aug 29 2024, 11:01 PM

Change #1068882 had a related patch set uploaded (by Bartosz Dziewoński; author: Mqudsi):

[mediawiki/extensions/VisualEditor@REL1_42] Fix exception editing cross-wiki redirects

https://gerrit.wikimedia.org/r/1068882

• matmarex added a comment.Aug 29 2024, 11:06 PM

Backporting as requested by @mqudsi (in discussion on the patch).

gerritbot added a comment.Aug 29 2024, 11:12 PM

Change #1068881 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@REL1_41] Fix exception editing cross-wiki redirects

https://gerrit.wikimedia.org/r/1068881

gerritbot added a comment.Aug 29 2024, 11:12 PM

Change #1068882 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@REL1_42] Fix exception editing cross-wiki redirects

https://gerrit.wikimedia.org/r/1068882

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2024, 11:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Aug 30 2024, 12:00 AM
mqudsi added a comment.Aug 31 2024, 8:54 PM

@matmarex thank you very much for your help with this and for taking on the backports. It's much appreciated!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits