Page MenuHomePhabricator

Confusing language alert when visiting a page with no languages and JS disabled
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT

Assigned To
Authored By
Jdlrobson
Jan 3 2023, 11:21 PM
Referenced Files
F37109892: Screenshot 2023-06-19 at 6.47.35 PM.png
Jun 20 2023, 1:55 AM
F37109891: Screenshot 2023-06-19 at 6.50.53 PM.png
Jun 20 2023, 1:55 AM
F37099692: image.png
Jun 10 2023, 12:40 AM
F37099675: Screenshot 2023-06-09 at 5.21.36 PM.png
Jun 10 2023, 12:21 AM
F37099674: Screenshot 2023-06-09 at 5.21.22 PM.png
Jun 10 2023, 12:21 AM
F36896802: Screenshot 2023-03-07 at 9.30.24 AM.png
Mar 7 2023, 5:31 PM
F36896800: Screenshot 2023-03-07 at 9.29.10 AM.png
Mar 7 2023, 5:31 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
An alert at bottom right of the page tells me languages are at the top of the page but they are not

Screen Shot 2023-01-03 at 3.20.47 PM.png (1×2 px, 245 KB)

What should have happened instead?:
The language alert should not display: Hide it the same way as we hide the language button.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1T326185#8947690

Event Timeline

Unclear to me if this is something the web or language team want to fix or whether we should just decline it?

@Pginer-WMF - I'm also not sure what to do with this ticket. Any thoughts from your side?

@Pginer-WMF - I'm also not sure what to do with this ticket. Any thoughts from your side?

Thanks for pinging. I think this connects with the broader question about which is the level of support we want to provide for the no-Js experience. It would be great to know if there is a general policy on this.

One option could be to show the language selector entry point (i.e., the "268 languages" label) but make it for the non-js context to link to [the Wikidata list of languages}(https://www.wikidata.org/wiki/Q405#sitelinks-wikipedia). In this way, basic functionality could be provided in this context to switch languages without investing high development resources.

Another option could be to keep the language selector unavailable in the non-JS context assuming that JS is nowadays a core part of HTML and it is ok to have features missing when any core technology is disabled (e.g., having a broken non-CSS experience). In this case, you ma want to hide the "links are at the top" notice for consistency, but it may be ok just to wait to remove such notice when it is no longer needed in general (i.e., new position becoming common across all wikis).

Hey I think there's some confusion here. There is no problem with the language button with JS disabled.

The language button doesn't show if they are no languages and shows as a dropdown if it is.

Screenshot 2023-03-07 at 9.29.10 AM.png (684×1 px, 289 KB)

The question here is about the languages alert on pages where there are no languages:

Screenshot 2023-03-07 at 9.30.24 AM.png (756×1 px, 290 KB)

There's just a decision to be made here with one of the three possible options:

  • Hide it the same way as we hide the language button.
  • If the alert is temporary, decline this ticket and wait until it gets removed.
  • Change the wording.

Thanks for the clarification, @Jdlrobson.
Hiding or waiting to get removed seem good options (depending on timeline of removal). If the note is eventually removed, adjusting the text may be not worth it compared to the other two options. But I'm ok with any approach the Web team decides on this.

I think hiding should be okay in this case (with future removal when we are live across all wikis)

Hey, I think we can just route it to open the languages from the dropdown directly if we click on the "go to top" link so that it would be more accurate rather than hiding it.

@Jdlrobson

Hey, I think we can just route it to open the languages from the dropdown directly if we click on the "go to top" link so that it would be more accurate rather than hiding it.

There is no language dropdown on the page in the example to route to. This is the issue.

Thanks for the clarification .Is there any other possible ways to resolve this issue rather than hiding it .If you could guide me, I am interested to learn it and possibly try to resolve it @Jdlrobson

Change 921396 had a related patch set uploaded (by Jayden Bailey; author: Jayden Bailey):

[mediawiki/skins/Vector@master] Hide language alert if there are none and JS is disabled

https://gerrit.wikimedia.org/r/921396

@JaydenKieran it looks like the languages button is showing with JavaScript disabled now on https://en.wikipedia.beta.wmflabs.org/wiki/Title-0.46881833986115273-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n so the language box is no longer confusing What do you think?

The bug still appears on https://en.wikipedia.org/wiki/106th_Regiment_of_Foot_(Black_Musqueteers) so perhaps the beta cluster has some new code that got recently added

Screenshot 2023-06-09 at 5.21.22 PM.png (598×1 px, 201 KB)

Screenshot 2023-06-09 at 5.21.36 PM.png (736×1 px, 128 KB)

?

Hey @Jdlrobson, I just had a look at the page you linked on the beta cluster but I don't actually get the same as you when JS is disabled. However, I'm not logged in, so I'm wondering if that makes a difference in what you see on that page. Maybe try with an incognito window/logged out? (or maybe there's some other variable at play here)

Screenshot 2023-06-10 at 01-29-07 Title-0.46881833986115273-Iñtërnâtiônàlizætiøn - Wikipedia the free encyclopedia.png (1×3 px, 407 KB)

If that is the case, then it still seems like a good idea to hide the message when JS is disabled since it is confusing to anons.

I made an account on the beta cluster - this is how the page looks to me with JS disabled.

image.png (1×3 px, 468 KB)

Yeh agree this sounds like a good idea then. I will take another look Monday. Thanks for the reply!

Change 921396 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide language alert if there are none and JS is disabled

https://gerrit.wikimedia.org/r/921396

Jdlrobson updated Other Assignee, added: JaydenKieran.
Jdlrobson added a subscriber: JaydenKieran.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Title-0.46881833986115273-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n
with JS disabled.

✅ AC1: The language alert in the main menu should not appear.

Screenshot 2023-06-19 at 6.50.53 PM.png (643×1 px, 148 KB)

Screenshot 2023-06-19 at 6.47.35 PM.png (643×1 px, 132 KB)

Jdlrobson claimed this task.