Page MenuHomePhabricator

Placeholder text of iOS app's Link editor is not dark mode compatible
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
TheDJ
Jan 4 2023, 10:33 AM
Referenced Files
F36973898: IMG_0509.PNG
May 3 2023, 5:31 PM
F36973897: IMG_40ED8879D7FE-1.jpeg
May 3 2023, 5:31 PM
F36973896: IMG_0511.PNG
May 3 2023, 5:31 PM
F36973895: IMG_0510.PNG
May 3 2023, 5:31 PM
F36973890: IMG_5138.PNG
May 3 2023, 5:31 PM
F36973889: IMG_1E040F948E7A-1.jpeg
May 3 2023, 5:31 PM
F36973888: IMG_5140.PNG
May 3 2023, 5:31 PM
F36973887: IMG_5139.PNG
May 3 2023, 5:31 PM

Description

Steps to replicate the issue (include links if applicable):

  • Set dark mode in the iOS app. I used the dark gray one
  • Bring up the editor for an article
  • Set the cursor on a blank line
  • From the editor toolbar, select "Link"

What happens?:
The link editor opens and shows a search field with a loupe, "search Wikipedia", or if you enter something, a clear-button.
These all show in a gray color instead of a light color. This makes them unreadable.

They should be light, like they are in the normal article search of the front page.

IMG_7195.PNG (2×1 px, 488 KB)

Related Objects

Event Timeline

LGoto triaged this task as Medium priority.Jan 9 2023, 7:38 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
LGoto added a project: good first task.
LGoto added a project: ios-app-v7.1.

@LGoto this seems to have already been fixed in 7.3.0, the placeholder text is properly colored:

blackgray
Simulator Screen Shot - iPhone 14 Pro - 2023-03-14 at 21.09.58.png (2×1 px, 101 KB)
Simulator Screen Shot - iPhone 14 Pro - 2023-03-14 at 21.09.35.png (2×1 px, 104 KB)

@contributor I'm still seeing the bug when I currently run in Xcode against main (so version 7.3.0). Here's using iPhone 14 simulator (iOS 16.2):

Screenshot 2023-03-15 at 11.55.49 AM (1×577 px, 206 KB)

I also see it on device in the App Store version 7.2.0. I'm running on an iPhone 12 mini, iOS version 16.2.

IMG_3BF7220468B6-1.jpeg (2×1 px, 410 KB)

@Gearthub Hi, sorry, is this task in progress? Otherwise I'd like to pick it up

Was unable to fix the problem, you can give it a go. Sorry for the late reaction.

Sandeepkrofc changed the task status from Open to In Progress.Apr 11 2023, 9:43 PM
Tsevener assigned this task to ABorbaWMF.
Tsevener added a subscriber: Sandeepkrofc.

Looks better on 7.3.0 (2183)

iPad text is fairly bright and readable. On the iPhone, it is a bit darker

iPhone -

IMG_5139.PNG (2×1 px, 215 KB)

IMG_5140.PNG (2×1 px, 213 KB)

IMG_1E040F948E7A-1.jpeg (2×1 px, 351 KB)

IMG_5138.PNG (2×1 px, 388 KB)

iPad -

IMG_0510.PNG (2×1 px, 225 KB)

IMG_0511.PNG (2×1 px, 222 KB)

IMG_40ED8879D7FE-1.jpeg (2×1 px, 376 KB)

IMG_0509.PNG (2×1 px, 407 KB)