Page MenuHomePhabricator

Add primary key and drop unique index on securepoll_properties on wmf wikis
Closed, ResolvedPublic

Description

Apply T312280 to wmf wikis

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/817868/4/sql/mysql/patch-securepoll_properties-unique-to-pk.sql
  2. Where to run those changes: sX
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta already running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Due to a bug in the schema change generator (T314138) the DROP + ALTER should be rewritten to be atomic:

alter table securepoll_properties drop key sppr_entity, ADD  PRIMARY KEY (pr_entity, pr_key);

Progress

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8
  • labtestwiki

Event Timeline

Marostegui triaged this task as Medium priority.
Marostegui moved this task from Triage to Ready on the DBA board.

Change 875307 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/software/schema-changes@master] drop_sppr_entity_T326221.py: New schema change

https://gerrit.wikimedia.org/r/875307

Mentioned in SAL (#wikimedia-operations) [2023-01-04T13:53:03Z] <marostegui> dbmaint deploy schema change on s1 T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T13:54:03Z] <marostegui> dbmaint deploy schema change on s2 T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T13:55:14Z] <marostegui> dbmaint deploy schema change on s4 T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T13:56:18Z] <marostegui> dbmaint deploy schema change on s5 T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T13:57:03Z] <marostegui> dbmaint deploy schema change on s6 T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T13:57:46Z] <marostegui> dbmaint deploy schema change on s8 T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T13:58:42Z] <marostegui> dbmaint deploy schema change on s7 T326221

Change 875307 abandoned by Marostegui:

[operations/software/schema-changes@master] drop_sppr_entity_T326221.py: New schema change

Reason:

Not needed

https://gerrit.wikimedia.org/r/875307

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:02:51Z] <marostegui> dbmaint deploy schema change on s3 T326221

s3 is the last section being done, it will take around 5-6h

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:11:15Z] <marostegui> dbmaint deploy schema change on s1 eqiad T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:11:18Z] <marostegui> dbmaint deploy schema change on s2 eqiad T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:11:20Z] <marostegui> dbmaint deploy schema change on s3 eqiad T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:11:23Z] <marostegui> dbmaint deploy schema change on s4 eqiad T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:11:25Z] <marostegui> dbmaint deploy schema change on s5 eqiad T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:11:27Z] <marostegui> dbmaint deploy schema change on s6 eqiad T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:11:29Z] <marostegui> dbmaint deploy schema change on s7 eqiad T326221

Mentioned in SAL (#wikimedia-operations) [2023-01-04T14:11:31Z] <marostegui> dbmaint deploy schema change on s8 eqiad T326221

Marostegui updated the task description. (Show Details)

This is done