Page MenuHomePhabricator
Create Task
Maniphest T326278

Error: Cannot use object of type ContentTranslation\DTO\TranslationUnitDTO as array
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Error: Cannot use object of type ContentTranslation\DTO\TranslationUnitDTO as array
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.17/extensions/ContentTranslation/includes/CorporaLookup.php(87)
#0 /srv/mediawiki/php-1.40.0-wmf.17/extensions/ContentTranslation/includes/CorporaLookup.php(51): ContentTranslation\CorporaLookup::format(Wikimedia\Rdbms\MysqliResultWrapper)
#1 /srv/mediawiki/php-1.40.0-wmf.17/extensions/ContentTranslation/includes/ActionApi/ApiQueryContentTranslation.php(113): ContentTranslation\CorporaLookup->getByTranslationId(integer)
#2 /srv/mediawiki/php-1.40.0-wmf.17/extensions/ContentTranslation/includes/ActionApi/ApiQueryContentTranslation.php(56): ContentTranslation\ActionApi\ApiQueryContentTranslation->run()
#3 /srv/mediawiki/php-1.40.0-wmf.17/includes/api/ApiQuery.php(677): ContentTranslation\ActionApi\ApiQueryContentTranslation->execute()
#4 /srv/mediawiki/php-1.40.0-wmf.17/includes/api/ApiMain.php(1901): ApiQuery->execute()
#5 /srv/mediawiki/php-1.40.0-wmf.17/includes/api/ApiMain.php(878): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.40.0-wmf.17/includes/api/ApiMain.php(849): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.40.0-wmf.17/api.php(90): ApiMain->execute()
#8 /srv/mediawiki/php-1.40.0-wmf.17/api.php(45): wfApiMain()
#9 /srv/mediawiki/w/api.php(3): require(string)
#10 {main}
Impact
Notes

Seems to have been caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/865034.

Details

MediaWiki Version
1.40.0-wmf.17
Request URL
https://it.wikipedia.org/w/api.php?action=query&format=*&list=*&translationid=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CX: Fix transformation of TranslationUnitDTO to custom arraymediawiki/extensions/ContentTranslationwmf/1.40.0-wmf.18+4 -3
CX: Fix transformation of TranslationUnitDTO to custom arraymediawiki/extensions/ContentTranslationwmf/1.40.0-wmf.17+4 -3
CX: Fix usage of categories translation unit as arraymediawiki/extensions/ContentTranslationwmf/1.40.0-wmf.17+9 -1
CX: Fix transformation of TranslationUnitDTO to custom arraymediawiki/extensions/ContentTranslationmaster+4 -3
CX: Fix usage of categories translation unit as arraymediawiki/extensions/ContentTranslationmaster+9 -1
CX: Fix usage of categories translation unit as arraymediawiki/extensions/ContentTranslationmaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

Zabe created this task.Jan 4 2023, 11:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2023, 11:22 PM
Umherirrender added subscribers: ngkountas, santhosh, Umherirrender.Jan 4 2023, 11:47 PM

New code from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/865034 for T322521

thcipriani moved this task from Untriaged to Jan 2023 on the Wikimedia-production-error board.Jan 5 2023, 4:55 PM
TheresNoTime merged a task: T326360: Error: Cannot use object of type ContentTranslation\DTO\TranslationUnitDTO as array.Jan 5 2023, 9:40 PM
TheresNoTime subscribed.
gerritbot added a comment.Jan 9 2023, 8:11 AM

Change 876798 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Fix usage of categories translation unit as array

https://gerrit.wikimedia.org/r/876798

gerritbot added a project: Patch-For-Review.Jan 9 2023, 8:11 AM
santhosh triaged this task as High priority.Jan 9 2023, 8:13 AM
santhosh added a project: Language-Team (Language-2022-October-December).
santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-October-December) board.
ngkountas claimed this task.Jan 9 2023, 8:19 AM
santhosh mentioned this in T326455: Fatal Error when trying to access translation draft.Jan 9 2023, 8:35 AM
gerritbot added a comment.Jan 9 2023, 10:16 AM

Change 877105 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Fix usage of categories translation unit as array

https://gerrit.wikimedia.org/r/877105

gerritbot added a comment.Jan 9 2023, 10:30 AM

Change 877107 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Fix transformation of TranslationUnitDTO to custom array

https://gerrit.wikimedia.org/r/877107

gerritbot added a comment.Jan 9 2023, 11:05 AM

Change 877105 abandoned by Nik Gkountas:

[mediawiki/extensions/ContentTranslation@master] CX: Fix usage of categories translation unit as array

Reason:

Duplicate of Iec3473ebf41e63c7b0fbd023a5289d69987322bd

https://gerrit.wikimedia.org/r/877105

Pginer-WMF edited projects, added Language-Team (Language-2023-January-March); removed Language-Team (Language-2022-October-December).Jan 9 2023, 11:36 AM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-January-March) board.
gerritbot added a comment.Jan 9 2023, 1:56 PM

Change 877138 had a related patch set uploaded (by KartikMistry; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.17] CX: Fix usage of categories translation unit as array

https://gerrit.wikimedia.org/r/877138

gerritbot added a comment.Jan 9 2023, 2:08 PM

Change 876798 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Fix usage of categories translation unit as array

https://gerrit.wikimedia.org/r/876798

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 9 2023, 3:00 PM
gerritbot added a comment.Jan 10 2023, 3:50 AM

Change 877107 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Fix transformation of TranslationUnitDTO to custom array

https://gerrit.wikimedia.org/r/877107

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.19; 2023-01-16); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 10 2023, 4:00 AM
gerritbot added a comment.Jan 10 2023, 5:40 AM

Change 877219 had a related patch set uploaded (by KartikMistry; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.17] CX: Fix transformation of TranslationUnitDTO to custom array

https://gerrit.wikimedia.org/r/877219

gerritbot added a comment.Jan 10 2023, 8:36 AM

Change 877138 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.17] CX: Fix usage of categories translation unit as array

https://gerrit.wikimedia.org/r/877138

Stashbot added a comment.Jan 10 2023, 8:37 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-10T08:37:07Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:877138|CX: Fix usage of categories translation unit as array (T326278)]]

Stashbot added a comment.Jan 10 2023, 8:38 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-10T08:38:56Z] <kartik@deploy1002> kartik and kartik: Backport for [[gerrit:877138|CX: Fix usage of categories translation unit as array (T326278)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Jan 10 2023, 8:49 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-10T08:49:15Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:877138|CX: Fix usage of categories translation unit as array (T326278)]] (duration: 12m 08s)

gerritbot added a comment.Jan 10 2023, 8:52 AM

Change 877223 had a related patch set uploaded (by KartikMistry; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.18] CX: Fix transformation of TranslationUnitDTO to custom array

https://gerrit.wikimedia.org/r/877223

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 10 2023, 9:00 AM
gerritbot added a comment.Jan 10 2023, 9:05 AM

Change 877219 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.17] CX: Fix transformation of TranslationUnitDTO to custom array

https://gerrit.wikimedia.org/r/877219

Stashbot added a comment.Jan 10 2023, 9:05 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-10T09:05:32Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:877219|CX: Fix transformation of TranslationUnitDTO to custom array (T326278)]]

Stashbot added a comment.Jan 10 2023, 9:07 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-10T09:07:17Z] <kartik@deploy1002> kartik and kartik: Backport for [[gerrit:877219|CX: Fix transformation of TranslationUnitDTO to custom array (T326278)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Jan 10 2023, 9:14 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-10T09:14:52Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:877219|CX: Fix transformation of TranslationUnitDTO to custom array (T326278)]] (duration: 09m 20s)

ArielGlenn subscribed.Jan 10 2023, 12:45 PM

The weekly content translation dumps were also impacted by this, sample stack trace:

[e2d5d9d71060942e3def717f] [no req]   Error: Cannot use object of type ContentTranslation\DTO\TranslationUnitDTO as array
Backtrace:
from /srv/mediawiki/php-1.40.0-wmf.17/extensions/ContentTranslation/includes/CorporaLookup.php(87)
#0 /srv/mediawiki/php-1.40.0-wmf.17/extensions/ContentTranslation/includes/CorporaLookup.php(51): ContentTranslation\CorporaLookup::format(Wikimedia\Rdbms\MysqliResultWrapper)
#1 /srv/mediawiki/php-1.40.0-wmf.17/extensions/ContentTranslation/scripts/dump-corpora.php(140): ContentTranslation\CorporaLookup->getByTranslationId(integer)
#2 /srv/mediawiki/php-1.40.0-wmf.17/maintenance/includes/MaintenanceRunner.php(496): CXCorporaDump->execute()
#3 /srv/mediawiki/php-1.40.0-wmf.17/maintenance/doMaintenance.php(85): MediaWiki\Maintenance\MaintenanceRunner->run()
#4 /srv/mediawiki/php-1.40.0-wmf.17/extensions/ContentTranslation/scripts/dump-corpora.php(316): require_once(string)
#5 /srv/mediawiki/multiversion/MWScript.php(120): require_once(string)
#6 {main}

I expect if the merged fix takes care of the reported issue, it will fix this as well.

KartikMistry subscribed.Jan 10 2023, 1:07 PM
In T326278#8512364, @ArielGlenn wrote:

I expect if the merged fix takes care of the reported issue, it will fix this as well.

Yes. I have planned to backport deployment in wmf.18 too.

gerritbot added a comment.Jan 11 2023, 8:19 AM

Change 877223 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.18] CX: Fix transformation of TranslationUnitDTO to custom array

https://gerrit.wikimedia.org/r/877223

Stashbot added a comment.Jan 11 2023, 8:19 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T08:19:59Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:877223|CX: Fix transformation of TranslationUnitDTO to custom array (T326278)]]

Stashbot added a comment.Jan 11 2023, 8:21 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T08:21:48Z] <kartik@deploy1002> kartik and kartik: Backport for [[gerrit:877223|CX: Fix transformation of TranslationUnitDTO to custom array (T326278)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Jan 11 2023, 8:31 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T08:31:44Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:877223|CX: Fix transformation of TranslationUnitDTO to custom array (T326278)]] (duration: 11m 45s)

KartikMistry moved this task from In Review to Needs QA on the Language-Team (Language-2023-January-March) board.Jan 11 2023, 8:34 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.18; 2023-01-09); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 11 2023, 9:00 AM
EChukwukere-WMF subscribed.Jan 18 2023, 4:48 AM

TEST Status: QA PASS

Able to complete a translation en -> ig without any issues and not able to reproduce the above error

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2023-January-March) board.Jan 18 2023, 4:48 AM
Umherirrender closed this task as Resolved.Jan 27 2023, 10:54 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 27 2023, 11:30 PM
ArielGlenn added a comment.Feb 3 2023, 9:45 PM

Just noting that we haven't seen this error for the last two weeks so it looks like the issue is resolved for us (Content Translation dumps) as well.

EChukwukere-WMF added a comment.Feb 4 2023, 2:53 AM

Thank you @ArielGlenn

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits