Error: Call to a member function formatBlock() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	thcipriani
	Jan 5 2023, 5:04 PM

Description

Error

mwversion: 1.40.0-wmf.17
reqId: 57cd7bde-652d-45db-add9-4387f1e94e59
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Error: Call to a member function formatBlock() on null

exception.trace

from /srv/mediawiki/php-1.40.0-wmf.17/includes/actions/McrUndoAction.php(484)
#0 /srv/mediawiki/php-1.40.0-wmf.17/includes/actions/FormAction.php(82): McrUndoAction->getFormFields()
#1 /srv/mediawiki/php-1.40.0-wmf.17/includes/actions/FormAction.php(159): FormAction->getForm()
#2 /srv/mediawiki/php-1.40.0-wmf.17/includes/actions/McrUndoAction.php(150): FormAction->show()
#3 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(551): McrUndoAction->show()
#4 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(328): MediaWiki->performAction(ImagePage, Title)
#5 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(916): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(571): MediaWiki->main()
#7 /srv/mediawiki/php-1.40.0-wmf.17/index.php(50): MediaWiki->run()
#8 /srv/mediawiki/php-1.40.0-wmf.17/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Notes

Happening on commonswiki at a low volume

Details

Request URL: https://commons.wikimedia.org/w/index.php?action=mcrundo&title=*

	Subject	Repo	Branch	Lines +/-
	actions: Actually store CommentFormatter in McrUndoAction	mediawiki/core	wmf/1.40.0-wmf.17	+1 -0
	actions: Actually store CommentFormatter in McrUndoAction	mediawiki/core	master	+1 -0

Customize query in gerrit

Event Timeline

thcipriani created this task.Jan 5 2023, 5:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2023, 5:04 PM

thcipriani moved this task from Untriaged to Jan 2023 on the Wikimedia-production-error board.Jan 5 2023, 5:04 PM

Zabe subscribed.Jan 5 2023, 5:26 PM

Change 875979 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] actions: Actually store CommentFormatter in McrUndoAction

https://gerrit.wikimedia.org/r/875979

gerritbot added a project: Patch-For-Review.Jan 5 2023, 5:27 PM

Change 875979 merged by jenkins-bot:

[mediawiki/core@master] actions: Actually store CommentFormatter in McrUndoAction

https://gerrit.wikimedia.org/r/875979

Change 875915 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@wmf/1.40.0-wmf.17] actions: Actually store CommentFormatter in McrUndoAction

https://gerrit.wikimedia.org/r/875915

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 5 2023, 7:00 PM

Change 875915 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.17] actions: Actually store CommentFormatter in McrUndoAction

https://gerrit.wikimedia.org/r/875915

Mentioned in SAL (#wikimedia-operations) [2023-01-05T21:21:24Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:875915|actions: Actually store CommentFormatter in McrUndoAction (T326336)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-05T21:23:04Z] <samtar@deploy1002> samtar and zabe: Backport for [[gerrit:875915|actions: Actually store CommentFormatter in McrUndoAction (T326336)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2023, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-05T21:31:55Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:875915|actions: Actually store CommentFormatter in McrUndoAction (T326336)]] (duration: 10m 31s)

Zabe closed this task as Resolved.Jan 5 2023, 9:32 PM

Zabe claimed this task.

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 5 2023, 10:00 PM

Error: Call to a member function formatBlock() on nullClosed, ResolvedPublicPRODUCTION ERRORActions