Page MenuHomePhabricator

Missing styles on Special:Undelete for suppression deleted pages
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Login as oversighter
  • Create a new page
  • Open action=delete, click "Suppress data from administrators as well as others" and delete the page
  • From the success page click "1 deleted version" which brings you to Special:Undelete/<page>
  • Everything looks good, the "bytes" shown for the revision are in parenthesis
  • Login as sysop which is not an oversighter
  • Go to the same page and press "View or undelete one deleted edit?"

What happens?:
The page Special:Undelete/<page> looks "unstyled". The "bytes" are not in parenthesis and the "username removed" or "summary removed" are not grey-striked as before

What should have happened instead?:
The page should be styled, some elements needs to be grey-striked.

Other information (browser name/version, screenshots, etc.):

The styles are provided by module mediawiki.interface.helpers.styles. This is also loaded on Special:Undelete when a log entry is shown, but the page was suppressdeleted and only a log entry in the suppression log exists, which makes the page showing "No matching items in log." for the deletion log and no styling is loaded. The page itself needs to ensure the relevant styles are loaded, if or if not a log extract is shown.

Event Timeline

Umherirrender triaged this task as Low priority.

Change 876008 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Special:Undelete needs to load module mediawiki.interface.helpers.styles

https://gerrit.wikimedia.org/r/876008

Change 876008 merged by jenkins-bot:

[mediawiki/core@master] Special:Undelete needs to load module mediawiki.interface.helpers.styles

https://gerrit.wikimedia.org/r/876008