All pinned menus should automatically collapse below 1000px
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	Jan 5 2023, 10:31 PM

Description

Steps to reproduce

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?vectorpagetools=1
Make sure the main menu and page tools menu are pinned
Narrow the screen to less than 1000px wide

Expected: all menus should automatically collapse
Observed: tools menu and main menu stay in a single column

AC

main menu, toc, and page tools auto collapse at 1000px
"move to sidebar" and "hide" toggle buttons in pinnable header are hidden under 1000px

QA Results - Prod

AC	Status	Details
1	✅	T326364#8576364
2	✅	T326364#8576364

Details

Subject	Repo	Branch	Lines +/-
Override PinnableElement behaviour at low resolutions.	mediawiki/skins/Vector	master	+125 -12
Followup to 4d1c0b89 Override PinnableElement behaviour at low resolutions.	mediawiki/skins/Vector	master	+1 -1
Add ability to unpin pinnable headers at low resolution.	mediawiki/skins/Vector	master	+138 -25

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	ovasileva	T317884 [EPIC] Vector 2022 post-deployment work
Resolved	ovasileva	T302073 [GOAL] Page Tools available on all wikis
Resolved	• alexhollender_WMF	T324877 Style the page tools and main menu dropdown feature
Resolved	ovasileva	T326364 All pinned menus should automatically collapse below 1000px
Resolved	Jdlrobson	T327109 Handle case where screen is resized right after pinning a menu

Event Timeline

ovasileva triaged this task as High priority.Jan 5 2023, 10:31 PM

ovasileva created this task.

ovasileva removed • alexhollender_WMF as the assignee of this task.Jan 5 2023, 10:43 PM

ovasileva updated the task description. (Show Details)

Change 862317 had a related patch set uploaded (by Bernard Wang; author: Jdrewniak):

[mediawiki/skins/Vector@master] Add ability to unpin pinnable headers at low resolution.

https://gerrit.wikimedia.org/r/862317

gerritbot added a project: Patch-For-Review.Jan 6 2023, 3:38 PM

• alexhollender_WMF renamed this task from Tools menu should automatically pin at low resolutions to All pinned menus should automatically collapse below 1000px.Jan 6 2023, 5:41 PM

• alexhollender_WMF updated the task description. (Show Details)

bwang mentioned this in T324877: Style the page tools and main menu dropdown feature.Jan 9 2023, 4:46 PM

bwang updated the task description. (Show Details)

Jdlrobson edited projects, added Web-Team FY2022-23 Q3 Sprint 1; removed Web-Team-Backlog (Kanbanana-2022-23-Q2).Jan 9 2023, 5:07 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 9 2023, 7:03 PM

Jdlrobson moved this task from Ready for Development to Incoming on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 9 2023, 9:10 PM

Jdrewniak claimed this task.Jan 10 2023, 5:34 PM

Jdrewniak moved this task from Incoming to Design Review on the Web-Team FY2022-23 Q3 Sprint 1 board.

Jdrewniak moved this task from Design Review to Doing on the Web-Team FY2022-23 Q3 Sprint 1 board.

ovasileva set the point value for this task to 3.Jan 10 2023, 5:49 PM

Change 878959 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Override PinnableElement behaviour at low resolutions.

https://gerrit.wikimedia.org/r/878959

Jdrewniak removed Jdrewniak as the assignee of this task.Jan 11 2023, 5:40 PM

Jdrewniak moved this task from Doing to Code Review on the Web-Team FY2022-23 Q3 Sprint 1 board.

Jdlrobson claimed this task.Jan 11 2023, 5:41 PM

Change 862317 abandoned by Jdrewniak:

[mediawiki/skins/Vector@master] Add ability to unpin pinnable headers at low resolution.

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/878959

https://gerrit.wikimedia.org/r/862317

Jdlrobson reassigned this task from Jdlrobson to Jdrewniak.Jan 12 2023, 9:59 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team FY2022-23 Q3 Sprint 1 board.

Change 878959 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Override PinnableElement behaviour at low resolutions.

https://gerrit.wikimedia.org/r/878959

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 13 2023, 8:00 PM

Jdlrobson moved this task from Needs More Work to QA on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 13 2023, 8:02 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2023, 8:30 PM

Change 879873 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Followup to 4d1c0b89 Override PinnableElement behaviour at low resolutions.

https://gerrit.wikimedia.org/r/879873

gerritbot added a project: Patch-For-Review.Jan 13 2023, 10:23 PM

Change 879873 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Followup to 4d1c0b89 Override PinnableElement behaviour at low resolutions.

https://gerrit.wikimedia.org/r/879873

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2023, 11:30 PM

main menu, toc, and page tools auto collapse at 1000px

"move to sidebar" and "hide" toggle buttons in pinnable header are hidden under 1000px

Looks good on beta with the exception of the empty state @alexhollender_WMF flagged. Moving to QA in prod

Jdlrobson moved this task from Incoming to Page Tools on the Desktop Improvements (Vector 2022) board.Jan 18 2023, 3:49 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.wikipedia.org/wiki/Hooded_skunk
Make sure the main menu and page tools menu are pinned
Narrow the screen to less than 1000px wide
✅ AC1: main menu, toc, and page tools auto collapse at 1000px
✅ AC2: "move to sidebar" and "hide" toggle buttons in pinnable header are hidden under 1000px

Screen Recording 2023-01-31 at 1.59.46 PM.mov.gif (698×1 px, 2 MB)

Edtadros updated the task description. (Show Details)Jan 31 2023, 10:05 PM

ovasileva closed this task as Resolved.Feb 3 2023, 3:56 PM

Jdlrobson closed subtask T327109: Handle case where screen is resized right after pinning a menu as Resolved.Feb 23 2023, 1:21 AM

	F36571421: Screen Recording 2023-01-31 at 1.59.46 PM.mov.gif
	Jan 31 2023, 10:02 PM

All pinned menus should automatically collapse below 1000pxClosed, ResolvedPublic3 Estimated Story PointsActions