Localhost debugging:

urbanecm@notebook  ~/unsynced/gerrit/mediawiki/core
$ !php
php maintenance/shell.php --wiki=awiki

*******************************************************************************
NOTE: Do not run maintenance scripts directly, use maintenance/run.php instead!
      Running scripts directly has been deprecated in MediaWiki 1.40.
      It may not work for some (or any) scripts in the future.
*******************************************************************************

Psy Shell v0.11.8 (PHP 7.4.33 — cli) by Justin Hileman
>>> \MediaWiki\Extension\CentralAuth\GlobalRename\GlobalRenameUserStatus::getInProgressRenames(User::newFromName('Martin Urbanec'))
Wikimedia\Rdbms\DBQueryError with message 'Error 1146: Table 'awiki.renameuser_status' doesn't exist
Function: MediaWiki\Extension\CentralAuth\GlobalRename\GlobalRenameUserStatus::getInProgressRenames
Query: SELECT DISTINCT ru_oldname,ru_newname  FROM `renameuser_status`
'
>>> use MediaWiki\Extension\CentralAuth\CentralAuthServices;
>>> $dbr = CentralAuthServices::getDatabaseManager()->getCentralDB( DB_REPLICA );
=> Wikimedia\Rdbms\DBConnRef {#4034}

>>> $qb = $dbr->newSelectQueryBuilder();
=> Wikimedia\Rdbms\SelectQueryBuilder {#4639}

>>> $qb->select( [ 'ru_oldname', 'ru_newname' ] ) ->distinct()->from( 'renameuser_status' );
=> Wikimedia\Rdbms\SelectQueryBuilder {#4639}

>>> $res = $qb ->caller( __METHOD__ )->fetchResultSet();
=> Wikimedia\Rdbms\MysqliResultWrapper {#4619}

>>> $ret = [];
=> []

>>> foreach ( $res as $row ) { $ret[$row->ru_oldname] = $row->ru_newname;}
>>> $ret
=> []

>>>

You can see it talks to the wrong database when calling the method, but when copy pasting exactly the same code from the method definition, it works as expected.

Reverting 49a7bc9f054f63a0f0637d2bbbadf4f0ae38b46c by @Zabe fixes the issue.

Change 876050 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@master] Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder"

https://gerrit.wikimedia.org/r/876050

Change 876051 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@wmf/1.40.0-wmf.17] Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder"

https://gerrit.wikimedia.org/r/876051

Change 876051 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.40.0-wmf.17] Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder"

https://gerrit.wikimedia.org/r/876051

Mentioned in SAL (#wikimedia-operations) [2023-01-06T00:59:14Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:876051|Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder" (T326377 T312394)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-06T01:01:01Z] <urbanecm@deploy1002> urbanecm and urbanecm: Backport for [[gerrit:876051|Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder" (T326377 T312394)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-06T01:08:03Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:876051|Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder" (T326377 T312394)]] (duration: 08m 48s)

Tagging RDBMS (+the Performance team) as well, as it looks to be a bug somewhere within the library, rather than in the caller (CentralAuth). See T326377#8503696 for the symptoms of the issue.

I have triple checked the patch and I can't find a case where the db object is being sent incorrectly. Debugging.

Might be a reproducible case of T193565: Foreign query for metawiki fails with "Table 'centralauth.page' doesn't exist" (DBConnRef mixup?)

Am I missing something in reproducing the error?

ladsgroup@mwmaint1002:~$ mwscript shell.php --wiki=metawiki
Psy Shell v0.11.8 (PHP 7.4.33 — cli) by Justin Hileman
>>> use MediaWiki\Extension\CentralAuth\CentralAuthServices;
>>> $dbr = CentralAuthServices::getDatabaseManager()->getCentralDB( DB_REPLICA );
=> Wikimedia\Rdbms\DBConnRef {#5868}

>>> $qb = $dbr->newSelectQueryBuilder();
=> Wikimedia\Rdbms\SelectQueryBuilder {#5879}

>>> $qb->select( [ 'ru_oldname', 'ru_newname' ] ) ->distinct()->from( 'renameuser_status' );
=> Wikimedia\Rdbms\SelectQueryBuilder {#5879}

>>> $res = $qb ->caller( __METHOD__ )->fetchResultSet();
=> Wikimedia\Rdbms\MysqliResultWrapper {#5849}

>>> $ret = [];
=> []

>>> foreach ( $res as $row ) { $ret[$row->ru_oldname] = $row->ru_newname;}
>>> $ret
=> [
     "Edegouges.olymp" => "Pot2000",
   ]

I can reproduce it in mwdebug. Debugging.

So far, the table name is set correctly.

I'm fairly certain at this point that this is T193565: Foreign query for metawiki fails with "Table 'centralauth.page' doesn't exist" (DBConnRef mixup?) which actually didn't get fixed. The reason is something along the lines of lb/lbf being initialized with metawiki db and lb reusing the metawiki connection because both are on s7 but failing to set the db correctly (probably setting it too late, e.g. after db prefix is added or something like that) and then exploding majestically. Trying to see what I can do to fix this.

Change 876222 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Stop tracking LBs based on section and track them based on domain

https://gerrit.wikimedia.org/r/876222

Merged the revert since we have no proper fix yet.

Change 876050 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder"

https://gerrit.wikimedia.org/r/876050

In T326377#8504974, @Ladsgroup wrote:

I can reproduce it in mwdebug. Debugging.

So far, the table name is set correctly.

Did you find updated lines of code that I can put in shell.php/eval.php to reproduce?

In T326377#8518577, @aaron wrote:

In T326377#8504974, @Ladsgroup wrote:

I can reproduce it in mwdebug. Debugging.

So far, the table name is set correctly.

Did you find updated lines of code that I can put in shell.php/eval.php to reproduce?

It is in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/812552/7/includes/GlobalRename/GlobalRenameUserStatus.php (GlobalRenameUserStatus::getInProgressRenames).

But it won't work in shell.php/eval.php. You must change it in mwdebug and then go to https://meta.wikimedia.org/wiki/Special:GlobalRenameProgress

The problem is from:

$qb = $dbr->newSelectQueryBuilder();
...
if ( !$performer->isAllowed( 'centralauth-suppress' ) ) {

The query build wraps the Database, not the DBConnRef, and isAllowed() is triggered a domain change on the Database handle. Once fetchResultSet() is called, there is nothing to switch the domain back.

I created an empty 'remotewiki' db to repro this pattern locally:

$dbr = wfGetDB( DB_REPLICA, [], false );
$qb = $dbr->newSelectQueryBuilder();
wfGetDB( DB_REPLICA, [], 'remotewiki' )->ensureConnection();
$qb->select( [ 'page_id' ] )->from( 'page' )->limit( 1 )->caller( __METHOD__ )->fetchResultSet();

Which gives:

Error 1146: Table 'remotewiki.page' doesn't exist

This works without the ensureConnection() line.

Change 881024 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Use DBConnRef in SelectQueryBuilder

https://gerrit.wikimedia.org/r/881024

Change 881027 had a related patch set uploaded (by Krinkle; author: Tim Starling):

[mediawiki/core@REL1_38] rdbms: Use DBConnRef in SelectQueryBuilder

https://gerrit.wikimedia.org/r/881027

Change 881028 had a related patch set uploaded (by Krinkle; author: Tim Starling):

[mediawiki/core@REL1_39] rdbms: Use DBConnRef in SelectQueryBuilder

https://gerrit.wikimedia.org/r/881028

Change 881024 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Use DBConnRef in SelectQueryBuilder

https://gerrit.wikimedia.org/r/881024

Change 881027 merged by jenkins-bot:

[mediawiki/core@REL1_38] rdbms: Use DBConnRef in SelectQueryBuilder

https://gerrit.wikimedia.org/r/881027

Change 881028 merged by jenkins-bot:

[mediawiki/core@REL1_39] rdbms: Use DBConnRef in SelectQueryBuilder

https://gerrit.wikimedia.org/r/881028

Change 876222 abandoned by Ladsgroup:

[mediawiki/core@master] rdbms: Stop tracking LBs based on section and track them based on domain

Reason:

Done in a better way

https://gerrit.wikimedia.org/r/876222