Page MenuHomePhabricator

Use of "self" in callables is deprecated in php8.2 from wikimedia/php-cssjanus
Closed, ResolvedPublic

Description

Created https://github.com/wikimedia/php-cssjanus/issues/36

11:34:34 18) MediaWiki\Tests\ResourceLoader\FileModuleTest::testMixedCssAnnotations
11:34:34 Use of "self" in callables is deprecated
11:34:34 
11:34:34 /workspace/src/vendor/cssjanus/cssjanus/src/CSSJanus.php:311
11:34:34 /workspace/src/vendor/cssjanus/cssjanus/src/CSSJanus.php:193
11:34:34 /workspace/src/includes/ResourceLoader/FileModule.php:1015
11:34:34 /workspace/src/includes/ResourceLoader/FileModule.php:986
11:34:34 /workspace/src/includes/ResourceLoader/FileModule.php:964
11:34:34 /workspace/src/includes/ResourceLoader/FileModule.php:395
11:34:34 /workspace/src/tests/phpunit/includes/ResourceLoader/FileModuleTest.php:339
11:34:34 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:500
11:34:34 /workspace/src/tests/phpunit/phpunit.php:101
11:34:34 /workspace/src/tests/phpunit/phpunit.php:153
11:34:34 === Logs generated by test case
11:34:34 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
11:34:34 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
11:34:34 ===
11:34:34 
11:34:34 19) MediaWiki\Tests\ResourceLoader\FileModuleTest::testCssFlipping
11:34:34 Use of "self" in callables is deprecated
11:34:34 
11:34:34 /workspace/src/vendor/cssjanus/cssjanus/src/CSSJanus.php:311
11:34:34 /workspace/src/vendor/cssjanus/cssjanus/src/CSSJanus.php:193
11:34:34 /workspace/src/includes/ResourceLoader/FileModule.php:1015
11:34:34 /workspace/src/includes/ResourceLoader/FileModule.php:986
11:34:34 /workspace/src/includes/ResourceLoader/FileModule.php:964
11:34:34 /workspace/src/includes/ResourceLoader/FileModule.php:395
11:34:34 /workspace/src/tests/phpunit/includes/ResourceLoader/FileModuleTest.php:360
11:34:34 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:500
11:34:34 /workspace/src/tests/phpunit/phpunit.php:101
11:34:34 /workspace/src/tests/phpunit/phpunit.php:153
11:34:34 === Logs generated by test case
11:34:34 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
11:34:34 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
11:34:34 ===

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy moved this task from Reported Upstream to Patch merged upstream on the Upstream board.

Fix merged upstream, no release tagged yet.

PHP 8.2 CI not passing due to waiting on a relase of phan-taint-check-plugin that includes https://github.com/wikimedia/phan-taint-check-plugin/commit/fc31270ae44a72ad2eb482fab4a3f7be1135053d (do we have a task for that?)

Fix merged upstream, no release tagged yet.

PHP 8.2 CI not passing due to waiting on a relase of phan-taint-check-plugin that includes https://github.com/wikimedia/phan-taint-check-plugin/commit/fc31270ae44a72ad2eb482fab4a3f7be1135053d (do we have a task for that?)

There is no task for taint to release that fix, a point release would be nice to get other libs running on php8.2 as well.

Krinkle triaged this task as Medium priority.
Krinkle removed a project: Upstream.

In semver-land it should've been v3 (due to dropping old PHP support)... But I guess as the versioning is following/matching the upstream versioning of https://github.com/cssjanus/cssjanus it's ok...

But what do we do, if upstream then release a 2.1.1? :)

In semver-land it should've been v3 (due to dropping old PHP support)... But I guess as the versioning is following/matching the upstream versioning of https://github.com/cssjanus/cssjanus it's ok...

But what do we do, if upstream then release a 2.1.1? :)

I don't think I documented this anywhere, but the version parity policy applies to the spec'ed I/O behaviour. Patch release should be specific to the Node.js or PHP implementation. The PHP port validates itself against the spec, and spec additions/changes are at least semver-minor.

Change 877294 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@master] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/877294

Change 877295 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/877295

Change 877294 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/877294

Change 877295 merged by jenkins-bot:

[mediawiki/core@master] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/877295

Change 879151 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/879151

Change 879154 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_39] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/879154

Change 879155 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_38] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/879155

Change 879154 merged by Reedy:

[mediawiki/vendor@REL1_39] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/879154

Change 879155 merged by Reedy:

[mediawiki/vendor@REL1_38] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/879155

Change 879156 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/879156

Change 879157 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_38] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/879157

Change 879157 abandoned by Reedy:

[mediawiki/core@REL1_38] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

Reason:

Actually no, PHP versions

https://gerrit.wikimedia.org/r/879157

Backport should be trivial enough.

Actually, not for 1.38; because of the PHP version bump.

Change 879156 merged by jenkins-bot:

[mediawiki/core@REL1_39] Upgrading cssjanus/cssjanus (v2.1.0 => v2.1.1)

https://gerrit.wikimedia.org/r/879156

Krinkle reassigned this task from Krinkle to Reedy.