Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Jan 7 2023, 8:24 PM

Description

With php8.2 the unit tests get a failure

5) ApiEditPageTest::testEditAbortedByEditPageHookWithResult
Creation of dynamic property Status::$apiHookResult is deprecated

/workspace/src/includes/Status.php:109
/workspace/src/tests/phpunit/includes/api/ApiEditPageTest.php:1635

It is also used by ConfirmEdit extension.

https://codesearch.wmcloud.org/search/?q=apiHookResult&i=nope&files=&excludeFiles=&repos=

One solution could be a ApiStatus object extends Status, like the PageUpdateStatus

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Fix dynamic property usage	mediawiki/extensions/ConfirmEdit	REL1_39	+2 -2
Fix dynamic property usage	mediawiki/extensions/ConfirmEdit	REL1_41	+2 -2
Fix dynamic property usage	mediawiki/extensions/ConfirmEdit	REL1_40	+2 -2
StatusValue: Allow passing arbitrary data to augment result	mediawiki/core	REL1_39	+14 -3
StatusValue: Allow passing arbitrary data to augment result	mediawiki/core	REL1_40	+14 -3
StatusValue: Allow passing arbitrary data to augment result	mediawiki/core	REL1_41	+14 -3
StatusValue: Allow passing arbitrary data to augment result	mediawiki/core	master	+17 -6
Fix dynamic property usage	mediawiki/extensions/ConfirmEdit	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T314099 PHP 8.2: Dynamic property creation is deprecated
		Resolved		Ammarpad	T326479 Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook

Event Timeline

Umherirrender created this task.Jan 7 2023, 8:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2023, 8:24 PM

Umherirrender added a parent task: T314099: PHP 8.2: Dynamic property creation is deprecated.Jan 7 2023, 8:24 PM

Umherirrender moved this task from Backlog to MediaWiki core on the PHP 8.2 support board.Jan 7 2023, 9:00 PM

Umherirrender mentioned this in T314099: PHP 8.2: Dynamic property creation is deprecated.Jan 10 2023, 4:42 PM

Umherirrender unsubscribed.Mar 13 2023, 7:53 PM

Jdforrester-WMF mentioned this in T352085: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries).Nov 27 2023, 7:36 PM

Ammarpad closed this task as Resolved.Nov 28 2023, 10:48 AM

Ammarpad reopened this task as In Progress.

Ammarpad claimed this task.

Change 978048 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/978048

gerritbot added a project: Patch-For-Review.Nov 28 2023, 1:05 PM

Change 978053 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/ConfirmEdit@master] Fix dynamic property usage

https://gerrit.wikimedia.org/r/978053

Change 978048 merged by jenkins-bot:

[mediawiki/core@master] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/978048

Change 978053 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Fix dynamic property usage

https://gerrit.wikimedia.org/r/978053

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2023, 2:30 PM

Ammarpad closed this task as Resolved.Nov 28 2023, 2:45 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Nov 28 2023, 3:00 PM

Reedy mentioned this in T361985: MW 1.39/1.40/1.41 core fixes needed for PHP 8.2/8.3.Apr 5 2024, 11:15 PM

Change #1017428 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_41] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017428

Change #1017429 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/extensions/ConfirmEdit@REL1_41] Fix dynamic property usage

https://gerrit.wikimedia.org/r/1017429

Change #1017428 merged by jenkins-bot:

[mediawiki/core@REL1_41] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017428

Change #1017442 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_40] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017442

Change #1017443 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/extensions/ConfirmEdit@REL1_40] Fix dynamic property usage

https://gerrit.wikimedia.org/r/1017443

Change #1017442 merged by jenkins-bot:

[mediawiki/core@REL1_40] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017442

Change #1017445 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_39] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017445

Change #1017445 merged by jenkins-bot:

[mediawiki/core@REL1_39] StatusValue: Allow passing arbitrary data to augment result

https://gerrit.wikimedia.org/r/1017445

Change #1017469 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/extensions/ConfirmEdit@REL1_39] Fix dynamic property usage

https://gerrit.wikimedia.org/r/1017469

Change #1017443 merged by jenkins-bot: