Page MenuHomePhabricator
Create Task
Maniphest T326490

mwbot-rs/parsoid: fails transforming html to wikitext if title is italic
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Find an article having an italicized title. (e.g. Father Ted)
  • Use get or get_revision (I haven't tested get, but I think they should work the same) to fetch that page into html
  • Then try to transform it to wikitext using transform_to_wikitext.

What happens?: It fails:

HTTP status client error (400 Bad Request) for url (https://en.wikipedia.org/api/rest_v1/transform/html/to/wikitext/%3Ci%3EFather%20Ted%3C%2Fi%3E/1129515675)

What should have happened instead?: Success

Software version (skip for WMF-hosted wikis like Wikipedia): parsoid = "0.7.4"

Other information (browser name/version, screenshots, etc.):

Details

ReferenceSource BranchDest BranchAuthorTitle
repos/mwbot-rs/mwbot!14title2-fixmainlegoktmHave Wikicode store a title instead of trying to parse it
repos/mwbot-rs/mwbot!13title-fixmainlegoktmExtract usable title from Parsoid HTML
Customize query in GitLab

Related Objects

Event Timeline

0xDeadbeef created this task.Jan 8 2023, 5:36 AM
0xDeadbeef edited projects, added mwbot-rs (parsoid); removed mwbot-rs.
0xDeadbeef edited subscribers, added: mwbot-rs (parsoid); removed: mwbot-rs.
Legoktm triaged this task as High priority.Jan 8 2023, 5:42 AM
Legoktm added a subscriber: Legoktm.

Hmm, I noticed part of this last month and filed T324431: Parsoid: displaytitle HTML now appearing in <title> element rather than page title but didn't realize it broke this too.

Legoktm claimed this task.Jan 8 2023, 5:46 AM
0xDeadbeef added a comment.Jan 8 2023, 6:07 AM

The main part of this problem is that when converting Wikicode to ImmutableWikicode it tries to parse the title from HTML and stores that. Until this is fixed from parsoid's API side a temporary fix would be to store the original provided title within Wikicode and use that when converting to the immutable one.

gerritbot added a comment.Jan 8 2023, 6:11 AM

legoktm opened https://gitlab.wikimedia.org/repos/mwbot-rs/mwbot/-/merge_requests/13

Extract usable title from Parsoid HTML

Legoktm added a comment.Jan 8 2023, 6:17 AM
In T326490#8507022, @0xDeadbeef wrote:

The main part of this problem is that when converting Wikicode to ImmutableWikicode it tries to parse the title from HTML and stores that. Until this is fixed from parsoid's API side a temporary fix would be to store the original provided title within Wikicode and use that when converting to the immutable one.

Yeah, that's a good idea too. I put up a MR fixing .title() if you want to take a look, but I like your idea so it isn't even called in the common case. Do you want to work on a patch for that or should I?

gerritbot added a comment.Jan 8 2023, 6:39 PM

legoktm opened https://gitlab.wikimedia.org/repos/mwbot-rs/mwbot/-/merge_requests/14

Have Wikicode store a title instead of trying to parse it

gerritbot added a comment.Jan 8 2023, 6:45 PM

legoktm merged https://gitlab.wikimedia.org/repos/mwbot-rs/mwbot/-/merge_requests/14

Have Wikicode store a title instead of trying to parse it

Legoktm closed this task as Resolved.Jan 8 2023, 7:06 PM

parsoid 0.7.5 has been released with the fix.

Aklapper removed a subscriber: mwbot-rs (parsoid).May 16 2023, 11:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL