Page MenuHomePhabricator
Create Task
Maniphest T326530

Map point focus rectangles are not shown for dynamic mapframe wikis AND click area is too big on static mapframe wikis
Closed, ResolvedPublic
Actions

Description

Due to a clipping rectangle hack introduced in T141750, focus rectangles are invisible on dynamic mapframe wikis, for example https://en.wikivoyage.org/wiki/Salzburg#/map/0 . Lack of this workaround causes a regression on static mapframe wikis: the clickable area for points is 2x taller than desired, and the focus rectangle is stretched.

Details

SubjectRepoBranchLines +/-
Adjust padding of map marker selection rectanglesmediawiki/extensions/Kartographermaster+2 -0
Use more robust object-fit: cover for marker iconsmediawiki/extensions/Kartographermaster+1 -1
Fix large focus rectangle on map markers with modern CSSmediawiki/extensions/Kartographermaster+20 -0
[POC] Replace hard-coded <img> with custom <div> markersmediawiki/extensions/Kartographermaster+19 -4
Replace hard-coded clip rectangle hack with more flexible CSSmediawiki/extensions/Kartographermaster+6 -20
Fix slightly to large map marker click regionmediawiki/extensions/Kartographermaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Jan 9 2023, 9:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2023, 9:03 AM
awight added a parent task: T315861: Style markers for show nearby feature.Jan 9 2023, 9:04 AM
awight updated the task description. (Show Details)Jan 9 2023, 9:21 AM
gerritbot added a comment.Jan 9 2023, 9:31 AM

Change 877096 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Fix slightly to large map marker click region

https://gerrit.wikimedia.org/r/877096

gerritbot added a project: Patch-For-Review.Jan 9 2023, 9:31 AM
gerritbot added a comment.Jan 9 2023, 10:02 AM

Change 877103 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Replace hard-coded clip rectangle hack with more flexible CSS

https://gerrit.wikimedia.org/r/877103

lilients_WMDE moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.Jan 9 2023, 10:36 AM
thiemowmde claimed this task.Jan 9 2023, 11:22 AM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-01-04 board.
lilients_WMDE mentioned this in T315861: Style markers for show nearby feature.Jan 9 2023, 1:23 PM
thiemowmde moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2023-01-04 board.Jan 10 2023, 9:52 AM
gerritbot added a comment.Jan 10 2023, 4:42 PM

Change 878131 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Replace hard-coded <img> with custom <div> markers

https://gerrit.wikimedia.org/r/878131

gerritbot added a comment.Jan 11 2023, 1:51 PM

Change 878942 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Replace clip rectangle hack on map markers with modern CSS

https://gerrit.wikimedia.org/r/878942

gerritbot added a comment.Jan 11 2023, 3:59 PM

Change 877096 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix slightly to large map marker click region

https://gerrit.wikimedia.org/r/877096

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 11 2023, 5:00 PM
gerritbot added a comment.Jan 12 2023, 11:40 AM

Change 877103 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Replace hard-coded clip rectangle hack with more flexible CSS

https://gerrit.wikimedia.org/r/877103

gerritbot added a comment.Jan 12 2023, 4:54 PM

Change 878131 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] [POC] Replace hard-coded <img> with custom <div> markers

Reason:

https://gerrit.wikimedia.org/r/878131

awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-01-04 board.Jan 13 2023, 11:48 AM
gerritbot added a comment.Jan 13 2023, 12:04 PM

Change 878942 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix large focus rectangle on map markers with modern CSS

https://gerrit.wikimedia.org/r/878942

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2023, 12:30 PM
gerritbot added a comment.Jan 13 2023, 12:36 PM

Change 879779 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Adjust padding of map marker selection rectangles

https://gerrit.wikimedia.org/r/879779

gerritbot added a project: Patch-For-Review.Jan 13 2023, 12:36 PM
gerritbot added a comment.Jan 13 2023, 3:07 PM

Change 879817 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Use more robust object-fit: cover for marker icons

https://gerrit.wikimedia.org/r/879817

gerritbot added a comment.Jan 13 2023, 3:26 PM

Change 879817 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use more robust object-fit: cover for marker icons

https://gerrit.wikimedia.org/r/879817

gerritbot added a comment.Jan 13 2023, 9:22 PM

Change 879779 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Adjust padding of map marker selection rectangles

https://gerrit.wikimedia.org/r/879779

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2023, 9:30 PM
awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2023-01-04 board.Jan 17 2023, 9:14 AM
thiemowmde closed this task as Resolved.Jan 18 2023, 9:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL