| kostajh | |
| Jan 9 2023, 5:40 PM |
| F36926291: Screen Shot 2023-03-24 at 3.42.09 PM.png | |
| Mar 24 2023, 10:57 PM |
| F36926293: Screen Shot 2023-03-24 at 3.50.23 PM.png | |
| Mar 24 2023, 10:57 PM |
| F36926286: Screen Shot 2023-03-24 at 3.41.36 PM.png | |
| Mar 24 2023, 10:57 PM |
| F36926281: Screen Shot 2023-03-24 at 3.41.19 PM.png | |
| Mar 24 2023, 10:57 PM |
| F36885067: Screen Shot 2023-02-28 at 12.22.15 PM.png | |
| Feb 28 2023, 8:32 PM |
| F36885065: Screen Shot 2023-02-28 at 12.16.20 PM.png | |
| Feb 28 2023, 8:32 PM |
| F36578069: image.png | |
| Feb 1 2023, 9:16 PM |
| F36578036: topics.gif | |
| Feb 1 2023, 8:49 PM |
In T305406: Newcomer tasks: quick analysis of AND selection usage, we learned that a significant number of users end up selecting multiple topics in AND mode, such that zero results are found. We should disable the "Save" button in topic dialog, so that the user can't end up in a no results state.
We should also add a "Change to "match all" filters" button on the no results screen if the Match ALL filter is selected, so that users can easily change by selecting that call-to-action.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T293695 [EPIC] Account creation | |||
| Resolved | KStoller-WMF | T301027 [Epic] Account creation: GLAM event materials | |||
| Resolved | Sgs | T301825 Account creation: add toggle to enable AND selection of interest topics | |||
| Resolved | Sgs | T305097 Newcomer tasks: Copy and UI improvements the AND selection of interest topics | |||
| Resolved | Sgs | T305399 Newcomer tasks: deploy AND selection to pilot wikis | |||
| Resolved | nettrom_WMF | T305406 Newcomer tasks: quick analysis of AND selection usage | |||
| Declined | None | T305408 Newcomer tasks: deploy AND selection to all wikis | |||
| Resolved | RHo | T325390 Suggested edits: Improve UX for "and" filtering leading to no suggestions found | |||
| Resolved | Sgs | T326579 Suggested edits topic dialog: Disable save when in AND mode, and no results are found |
I added a note about adding a CTA to switch the filter to "match all" in this error state in the task. However, per my comment on T325390#8501191, rather than considering improvements to this match all/match any filter dropdown, IMO it makes sense to reconsider continuing to develop this feature and instead work on T297117 to create a filtering method that is more user friendly to addressing the user need.
There is some delay between the user changing topic selection and us getting the number of tasks so we'd have to decide how to deal with that.
At the moment, we set the process dialog header to "in progress" mode when the user clicks Done, and the API request to save the user options isn't yet complete. The dialog closes once the user options save request finishes:
Maybe what we can do is, when the user clicks on a topic, set the process dialog header to "in progress" and disable "Done", and when the request completes, re-enable "Done".
At the moment, we set the process dialog header to "in progress" mode when the user clicks Done, and the API request to save the user options isn't yet complete. The dialog closes once the user options save request finishes:
Maybe what we can do is, when the user clicks on a topic, set the process dialog header to "in progress" and disable "Done", and when the request completes, re-enable "Done".
I added a proposal to change the "no results" screen when the "match all" is selected to include a cta that changes the filter back to Match any. I think it may be good enough as the quick fix solution before the longer term task to improve filtering. I think this could mitigate the need to disable the "Done" on the filter dialog, as besides the lag issue, as I also worry that people will get stuck not understanding why the "Done" can't be selected.
In this case, if one selecting the "Update filter" method to match any still results in no results, they will get the standard message about changing their topics or task selections.
Change 886379 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Suggested edits: disable action on filter dialogs when there are no results
Change 888201 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Suggested edits: add cta button to switch topic match mode from the no results view
Change 886379 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested edits: disable action on filter dialogs when there are no results
Change 888201 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested edits: add cta button to switch topic match mode from the no results view
@Sgs - "No suggestions found" screen cannot be reached at all (in betalabs and `wmf.23). When the number of the results is zero, the 'Done' button is disabled. Is it deliberate?
Yes, that is the purpose of this task.
One way to reach "No suggestions found" state is to get a task + topic filter combination with a low count, then either remove the unstructured task template from the tasks in the queue, or to do the add link / add image tasks in another tab. Then when reloading the page, you should see an empty state.
Thank you, @kostajh for the clarification!
When checking in testwiki wmf.25
We have another case when the "Edit" button is inactive but the left arrow button is active.
Change 894757 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Topics match mode: update the match mode in the FiltersStore
Change 894757 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Topics match mode: update the match mode in the FiltersStore
For @RHo review - the revised whole workflow for empty searches (see the detailed steps below) makes sense to me, but the following spec, probably, needs to be updated:
We should disable the "Save" button in topic dialog, so that the user can't end up in a no results state.
Checked testwiki wmf.1 - the current workflow is as follows:
 |  |
Thanks @Etonkovidova - agree that specification was superseded by the introduction of the "Update filter" CTA in the no results page. Otherwise this looks fine, thanks!
Checked testwiki wmf.1 - the current workflow is as follows:
- A user selects topics and AND filter (e.g. on testwiki select Architecture + Comics and anime) and gets the number of results as 0. Done button is active:
- A user clicks on the active Done button - the next screen instructs a user to click on Update filter to change to "Match at least one selected topic"
- A user clicks on Update filter button - the new results are displayed; the filter setting will be changed as expected: