Page MenuHomePhabricator
Create Task
Maniphest T326587

Replace core Message Box styles with Codex equivalents
Open, Stalled, LowPublic
Actions

Description

Can we replace the existing mw.ui Message Box styles with a new "CSS-only" version of the Message component?

This task is a spin-off from T321351: [EPIC] Add CSS-only components:

In T321351#8510761, @Jdlrobson wrote:

The big benefit of this work would presumably be icons and buttons in the web team, but I'd like to see the CSS mixin approach applied to cdx-message before approaching this use case to confirm its viable - https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/messageBoxes.less is our current legacy CSS for that (which is supposed to be synced with Codex) and the HTML is generated in https://github.com/wikimedia/mediawiki/blob/b8abc26010416ecc4b7d5576ecc50c37c3eb0519/includes/Html.php#L744
Is this something we can try first ?

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+24 -7[POC] Use Codex styles on message box component
Customize query in gerrit

Related Objects
Search...

Event Timeline

egardner created this task.Jan 9 2023, 8:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2023, 8:38 PM
egardner added a parent task: T321351: [EPIC] Add CSS-only components.Jan 9 2023, 8:38 PM
egardner mentioned this in T321351: [EPIC] Add CSS-only components.
egardner added a subscriber: Volker_E.Jan 9 2023, 8:46 PM
Volker_E added a comment.Jan 10 2023, 1:20 AM

@Jdlrobson One of the shortcomings in your comment from my understanding is, that the core MessageBox styles are also in use by the Installer. We need to have the styles in this file. A mediawiki.UI replacement wouldn't suffice here.

Volker_E renamed this task from Replace mw-ui MessageBox styles with Codex equivalents to Replace core Message Box styles with Codex equivalents.Jan 10 2023, 1:20 AM
Jdlrobson added a comment.Jan 10 2023, 5:31 PM

Why not? The WebInstaller uses ResourceLoader so would also benefit from the change. https://gerrit.wikimedia.org/g/mediawiki/core/+/c9fea125c78bfc017d6b549c5d6089498b0a5018/includes/installer/WebInstallerOutput.php#145

ldelench_wmf triaged this task as High priority.Jan 20 2023, 8:44 PM
ldelench_wmf moved this task from Requests to Needs Refinement on the Design-Systems-Team board.
ldelench_wmf added a subscriber: ldelench_wmf.

Adjusted priority based on priority of the parent epic, T321351. Feel free to edit!

ldelench_wmf lowered the priority of this task from High to Low.Feb 13 2023, 5:27 PM
ldelench_wmf removed a parent task: T321351: [EPIC] Add CSS-only components.Feb 13 2023, 6:25 PM
Jdlrobson added a subtask: T325105: [Epic] Add CSS-only versions of most Codex Vue components.Tue, Feb 28, 9:34 PM
gerritbot added a comment.Tue, Feb 28, 9:50 PM

Change 893061 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] [POC] Use Codex styles on message box component

https://gerrit.wikimedia.org/r/893061

gerritbot added a project: Patch-For-Review.Tue, Feb 28, 9:50 PM
Jdlrobson added a parent task: T330468: [EPIC] Enable use of CSS-only Codex components in MediaWiki.Tue, Mar 14, 10:10 PM

This task is blocked on T330468

Jdlrobson changed the task status from Open to Stalled.Tue, Mar 14, 10:10 PM
Jdlrobson added a project: Readers-Web-Backlog (Needs Prioritization (Tech)).
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL