Page MenuHomePhabricator
Create Task
Maniphest T326607

Future of liuggio/statsd-php-client?
Closed, ResolvedPublic
Actions

Description

Not sure who is the "internal"/WMF owner of our usage of https://github.com/liuggio/statsd-php-client

But we need to decide what to do about it's future.

June 2016 was the last meaningful commit to master. July 2015 was the last release.

https://github.com/liuggio/statsd-php-client/commits/v1.1.x/ is more active with various fixes from us.

Issues like T326386: Use of "self" in callables is deprecated in php8.2 from liuggio/statsd-php-client package will be a problem for us eventually... There's no massive rush, but it is unclear when this won't just be a deprecation inside PHP, and will be an exception/similar. Also affected by T376276: PHP 8.4: Implicitly nullable parameter declarations deprecated.

Lego asked for a new release in https://github.com/liuggio/statsd-php-client/issues/55 in October 2018 (for T110415: vendor/liuggio - file permissions trigger debian lintian warnings), to no response.

Do we want to fork? Find a replacement library?

A quick look suggests https://packagist.org/packages/league/statsd / https://github.com/thephpleague/statsd may be a candidate, as is actively maintained...

Related Objects
Search...

Event Timeline

Reedy created this task.Jan 10 2023, 1:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2023, 1:54 AM
Reedy added subscribers: Addshore, bd808, ori, Tgr.Jan 10 2023, 1:57 AM

CC @Tgr, @ori, @bd808 and @Addshore as a few people who have worked on this code/library usages over the years.

Reedy added a project: Grafana.Jan 10 2023, 1:58 AM
Reedy updated the task description. (Show Details)
ori added a comment.Jan 10 2023, 3:07 AM

It might be worth it to try and contact the library's co-maintainer. His contact info is at https://eatingco.de/about/.

Reedy added a comment.Jan 10 2023, 1:56 PM

I've emailed him, with a corrected email as the one on that page isn't right!

Reedy added a comment.Jan 10 2023, 2:07 PM
In T326607#8512510, @Reedy wrote:

I've emailed him, with a corrected email as the one on that page isn't right!

I've also asked if it's possible for one or more of "us" to get some rights on the repo...

I've started https://github.com/liuggio/statsd-php-client/pull/63 in an attempt to get CI running...

Tgr added a comment.Jan 11 2023, 3:28 AM

Statsd isn't exactly a moving target. We could just fork and fix the PHP compat issues. Given T240685: MediaWiki Prometheus support, it will have to be discarded soon anyway, so whatever takes the least effort, I suppose.

Reedy added a comment.Jan 11 2023, 11:49 PM
In T326607#8512510, @Reedy wrote:

I've emailed him, with a corrected email as the one on that page isn't right!

But that doesn't seem to work either.

ori added a comment.Jan 13 2023, 1:49 AM

+1 to @Tgr's proposal

Aklapper added a project: serviceops.Jan 18 2023, 4:17 PM
akosiaris edited projects, added serviceops-radar, observability; removed serviceops.Jan 23 2023, 4:36 PM
HouseBlaster moved this task from Unsorted to Needs research on the Technical-Debt board.Mar 4 2023, 11:04 PM
colewhite subscribed.Mar 21 2023, 10:14 PM
• lmata added a project: SRE Observability.Jul 18 2023, 11:12 PM
• lmata moved this task from Inbox to Radar on the observability board.
• lmata moved this task from Inbox to Radar on the SRE Observability board.
• lmata subscribed.
Reedy mentioned this in T203926: "Use of undefined constant SOL_UDP" in 1.31 image while using wgStatsdServer.Jan 10 2024, 5:41 PM
Reedy added a comment.Jan 10 2024, 5:51 PM

Is it worth moving forward on forking and updating this library for our various issues/use cases?

colewhite added a project: MediaWiki-libs-Stats.Jan 19 2024, 10:27 PM
Krinkle removed a project: Grafana.Mar 4 2024, 5:12 PM
Lucas_Werkmeister_WMDE subscribed.Jun 24 2024, 9:56 AM

I think this task would become obsolete with the completion of T343020: Converting MediaWiki Metrics to StatsLib – statslib doesn’t use this library AFAICT (it directly uses the sockets extension in \Wikimedia\IPUtils\UDPTransport::emit()).

colewhite added a comment.Jun 24 2024, 3:57 PM
In T326607#9917013, @Lucas_Werkmeister_WMDE wrote:

I think this task would become obsolete with the completion of T343020: Converting MediaWiki Metrics to StatsLib – statslib doesn’t use this library AFAICT (it directly uses the sockets extension in \Wikimedia\IPUtils\UDPTransport::emit()).

The backwards-compatibility feature copyToStatsdAt() still uses this library at the moment. It will be trivial to remove once backwards-compatibility is no longer needed.

Addshore unsubscribed.Jun 25 2024, 7:13 AM
ItamarWMDE mentioned this in T371616: [EPIC][GRAFMIGR] Spruce up Wikidata Grafana Metrics.Aug 1 2024, 3:01 PM
Umherirrender mentioned this in T376276: PHP 8.4: Implicitly nullable parameter declarations deprecated.Nov 10 2024, 1:58 AM
Umherirrender updated the task description. (Show Details)Nov 11 2024, 7:52 PM
Reedy added a comment.Nov 11 2024, 7:56 PM

https://github.com/liuggio/statsd-php-client/commit/e436e6bd09eb64ebab21ddacd20d0958389a3507 yay..

Reedy updated the task description. (Show Details)Nov 11 2024, 7:57 PM
Reedy updated the task description. (Show Details)Nov 11 2024, 8:03 PM
Reedy mentioned this in T379587: PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs.Nov 11 2024, 10:31 PM
Daimona subscribed.Dec 14 2024, 5:54 PM
colewhite added a comment.May 2 2025, 2:45 PM

Now that graphite is fully deprecated, I don't think we need this library any more.

colewhite mentioned this in T393186: Remove dependency on liuggio/statsd-php-client.May 2 2025, 2:48 PM
Jdforrester-WMF subscribed.Jul 24 2025, 5:48 PM
In T326607#10786265, @colewhite wrote:

Now that graphite is fully deprecated, I don't think we need this library any more.

There's a TODO at the top of includes/libs/Stats/BufferingStatsdDataFactory.php, but per code search there are a number of places it's used (cascading from there). Who would be the right person to re-write that class?

Krinkle closed this task as Resolved.Sep 29 2025, 7:37 PM
Krinkle assigned this task to colewhite.
Krinkle added a parent task: T393186: Remove dependency on liuggio/statsd-php-client.
Krinkle added a project: MediaWiki-Platform-Team (Radar).
Krinkle subscribed.

The decision about the "future" is resolved: It is being removed in favor of the wikimedia/stats lib. Details and remaining uses to be fleshed out at T393186.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits