Future of liuggio/statsd-php-client?
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Reedy
	Jan 10 2023, 1:54 AM

Description

Not sure who is the "internal"/WMF owner of our usage of https://github.com/liuggio/statsd-php-client

But we need to decide what to do about it's future.

6.5 years since any commits to master. 7.5 years since a release.

Issues like T326386: Use of "self" in callables is deprecated in php8.2 from liuggio/statsd-php-client package will be a problem for us eventually... There's no massive rush, but it is unclear when this won't just be a deprecation inside PHP, and will be an exception/similar.

Lego asked for a new release in https://github.com/liuggio/statsd-php-client/issues/55 in October 2018 (for T110415: vendor/liuggio - file permissions trigger debian lintian warnings), to no response.

Do we want to fork? Find a replacement library?

A quick look suggests https://packagist.org/packages/league/statsd / https://github.com/thephpleague/statsd may be a candidate, as is actively maintained...

Related Objects

Mentioned In: T203926: "Use of undefined constant SOL_UDP" in 1.31 image while using wgStatsdServer
Mentioned Here: T240685: MediaWiki Prometheus support
T110415: vendor/liuggio - file permissions trigger debian lintian warnings
T326386: Use of "self" in callables is deprecated in php8.2 from liuggio/statsd-php-client package

Event Timeline

Reedy created this task.Jan 10 2023, 1:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2023, 1:54 AM

CC @Tgr, @ori, @bd808 and @Addshore as a few people who have worked on this code/library usages over the years.

Reedy added a project: Grafana.Jan 10 2023, 1:58 AM

Reedy updated the task description. (Show Details)

It might be worth it to try and contact the library's co-maintainer. His contact info is at https://eatingco.de/about/.

I've emailed him, with a corrected email as the one on that page isn't right!

In T326607#8512510, @Reedy wrote:

I've emailed him, with a corrected email as the one on that page isn't right!

I've also asked if it's possible for one or more of "us" to get some rights on the repo...

I've started https://github.com/liuggio/statsd-php-client/pull/63 in an attempt to get CI running...

Statsd isn't exactly a moving target. We could just fork and fix the PHP compat issues. Given T240685: MediaWiki Prometheus support, it will have to be discarded soon anyway, so whatever takes the least effort, I suppose.