Page MenuHomePhabricator

Implement participant selection logic and interface
Closed, ResolvedPublic

Description

As an organiser, I want to be able to select participants to send emails to
And when I send an email it should be delivered only to those participants I have selected

As a participant,
When I have configured an email address on my account
And my account is not suppressed
And I have not blocked the organiser from sending me emails
I want to be able to receive emails from organisers

Event Timeline

vaughnwalters subscribed.

As an organiser, I want to be able to select participants to send emails to
โœ… And when I send an email it should be delivered only to those participants I have selected

As a participant,
When I have configured an email address on my account
And my account is not suppressed ( I will need to test this on betacluster)
And I have not blocked the organiser from sending me emails
โœ… I want to be able to receive emails from organisers

Send functionality works on local, but I will want to test this on betacluster as well.

Screen Recording 2023-07-19 at 2.46.28 PM.gif (1ร—2 px, 1 MB)


One note @MHorsey-WMF, if an organizer does not have an email address, they are still able to click on the message participants button and it does not show a failure until the organizer clicks send on the messaging tab. Per this comment: T325098#8704990, the Message participants button should be disabled and have a tooltip if the organizer does not have an email address, and on the messaging tab send button should remain disabled and there should be an inline message warning the organizer that they need an email address to send a message.

Screen Recording 2023-07-19 at 2.11.32 PM.gif (1ร—2 px, 475 KB)

One note @MHorsey-WMF, if an organizer does not have an email address, they are still able to click on the message participants button and it does not show a failure until the organizer clicks send on the messaging tab. Per this comment: T325098#8704990, the Message participants button should be disabled and have a tooltip if the organizer does not have an email address, and on the messaging tab send button should remain disabled and there should be an inline message warning the organizer that they need an email address to send a message.

Screen Recording 2023-07-19 at 2.11.32 PM.gif (1ร—2 px, 475 KB)

Heya @MHorsey-WMF going back through this, on the participants tab, the message participants button is not disabled and the tooltip is not present if the organizer does not have an email address.

compbuild
Screenshot 2023-03-17 at 11.53.53.png (2ร—3 px, 385 KB)
Screenshot 2023-08-24 at 10.32.47 AM.png (368ร—1 px, 52 KB)

Also on the Message tab, There is no notice To message participants, you'll need an email address on your account. Add email.. Right now, it does not allow the organizer to add participants, but just sends them back to the participants tab.

compbuild
image.png (1ร—2 px, 134 KB)
Screen Recording 2023-08-24 at 10.33.15 AM.gif (1ร—1 px, 250 KB)

Change 953983 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Add warning when organizer does not have a set email address.

https://gerrit.wikimedia.org/r/953983

Change 953983 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add warning when organizer does not have a set email address.

https://gerrit.wikimedia.org/r/953983

vaughnwalters added a subscriber: gonyeahialam.

The AC in this task is met, but there are a few UI issues, and if these should go in another ticket I can make that instead:

  1. The search bar is in a different place now than where it is in the comp. Is this intentional?
  2. The Message participants button should be disabled (gray button) if the organizer does not have an email. The tool tip copy is correct, but right now it is on click of the button - @gonyeahialam can you clarify if this tooltip should appear on click or on hover of the disabled button?
compbuild
Screenshot 2023-03-17 at 11.53.53.png (2ร—3 px, 385 KB)
Screenshot 2023-09-18 at 7.39.34 PM.png (760ร—1 px, 119 KB)
  1. The To message participants... warning should go above the Recipients / Add recipients button
compbuild
image.png (1ร—2 px, 134 KB)
Screenshot 2023-09-18 at 7.45.31 PM.png (1ร—1 px, 155 KB)
  1. The Delete and Message participants buttons have a slight vertical alignment issue. When inspecting it you can see where it is off:
Screenshot 2023-09-18 at 9.05.09 PM.png (96ร—570 px, 13 KB)
Screenshot 2023-09-18 at 8.56.59 PM.png (104ร—594 px, 15 KB)
  1. The Delete button and the Message Participants button should not have any space between the buttons.
compbuild
Screenshot 2023-09-18 at 9.03.35 PM.png (100ร—652 px, 23 KB)
Screenshot 2023-09-18 at 9.05.09 PM.png (96ร—570 px, 13 KB)

The AC in this task is met, but there are a few UI issues, and if these should go in another ticket I can make that instead:

  1. The search bar is in a different place now than where it is in the comp. Is this intentional?

The build is correct. This page was updated for the Participant questions feature/tasks.

  1. The Message participants button should be disabled (gray button) if the organizer does not have an email. The tool tip copy is correct, but right now it is on click of the button - @gonyeahialam can you clarify if this tooltip should appear on click or on hover of the disabled button?
compbuild
Screenshot 2023-03-17 at 11.53.53.png (2ร—3 px, 385 KB)
Screenshot 2023-09-18 at 7.39.34 PM.png (760ร—1 px, 119 KB)

If we leave the button disabled then the tooltip will only show on hover. However, we can leave it as it is in the build where the button isn't disabled and the tooltip shows on click.

  1. The To message participants... warning should go above the Recipients / Add recipients button
compbuild
image.png (1ร—2 px, 134 KB)
Screenshot 2023-09-18 at 7.45.31 PM.png (1ร—1 px, 155 KB)

Yes, it is above. The warning is a central warning for the whole page.

  1. The Delete and Message participants buttons have a slight vertical alignment issue. When inspecting it you can see where it is off:
Screenshot 2023-09-18 at 9.05.09 PM.png (96ร—570 px, 13 KB)
Screenshot 2023-09-18 at 8.56.59 PM.png (104ร—594 px, 15 KB)
  1. The Delete button and the Message Participants button should not have any space between the buttons.
compbuild
Screenshot 2023-09-18 at 9.03.35 PM.png (100ร—652 px, 23 KB)
Screenshot 2023-09-18 at 9.05.09 PM.png (96ร—570 px, 13 KB)

Yes, the buttons are together, the component is called a ButtonGroupWidget (destructive and progressive ButtonWidget)

The AC in this task is met, but there are a few UI issues, and if these should go in another ticket I can make that instead:

  1. The search bar is in a different place now than where it is in the comp. Is this intentional?

The build is correct. This page was updated for the Participant questions feature/tasks.

Okay, great. ๐Ÿ‘


  1. The Message participants button should be disabled (gray button) if the organizer does not have an email. The tool tip copy is correct, but right now it is on click of the button - @gonyeahialam can you clarify if this tooltip should appear on click or on hover of the disabled button?
compbuild
Screenshot 2023-03-17 at 11.53.53.png (2ร—3 px, 385 KB)
Screenshot 2023-09-18 at 7.39.34 PM.png (760ร—1 px, 119 KB)

If we leave the button disabled then the tooltip will only show on hover. However, we can leave it as it is in the build where the button isn't disabled and the tooltip shows on click.

Okay thanks, leaving this as in then with no followup task.


  1. The To message participants... warning should go above the Recipients / Add recipients button
compbuild
image.png (1ร—2 px, 134 KB)
Screenshot 2023-09-18 at 7.45.31 PM.png (1ร—1 px, 155 KB)

Yes, it is above. The warning is a central warning for the whole page.

Created follow up task for this T346847


  1. The Delete and Message participants buttons have a slight vertical alignment issue. When inspecting it you can see where it is off:
Screenshot 2023-09-18 at 9.05.09 PM.png (96ร—570 px, 13 KB)
Screenshot 2023-09-18 at 8.56.59 PM.png (104ร—594 px, 15 KB)
  1. The Delete button and the Message Participants button should not have any space between the buttons.
compbuild
Screenshot 2023-09-18 at 9.03.35 PM.png (100ร—652 px, 23 KB)
Screenshot 2023-09-18 at 9.05.09 PM.png (96ร—570 px, 13 KB)

Yes, the buttons are together, the component is called a ButtonGroupWidget (destructive and progressive ButtonWidget)

Created followup task for this T346845


AC is met, created follow up tasks for UI issues, moving this to design sign off.

Created T346968 as a parent task for the remaining UX / UX changes

As the AC are met and we have a separate parent task for UX/UI changes, I am marking this work as Done.