Page MenuHomePhabricator
Create Task
Maniphest T326646

PHP Deprecated: Use of WikiPage::newFromID was deprecated in MediaWiki 1.36. [Called from Article::getOldIDFromRequest]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of WikiPage::newFromID was deprecated in MediaWiki 1.36. [Called from Article::getOldIDFromRequest]
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.17/includes/page/Article.php(304)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.40.0-wmf.17/includes/debug/MWDebug.php(381): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.40.0-wmf.17/includes/debug/MWDebug.php(352): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.40.0-wmf.17/includes/debug/MWDebug.php(233): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.40.0-wmf.17/includes/GlobalFunctions.php(770): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.40.0-wmf.17/includes/page/WikiPage.php(227): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.40.0-wmf.17/includes/page/Article.php(304): WikiPage::newFromID(integer)
#7 /srv/mediawiki/php-1.40.0-wmf.17/extensions/FlaggedRevs/frontend/FlaggablePageView.php(1365): Article->getOldIDFromRequest()
#8 /srv/mediawiki/php-1.40.0-wmf.17/extensions/FlaggedRevs/frontend/FlaggablePageView.php(273): FlaggablePageView->getOldIDFromRequest()
#9 /srv/mediawiki/php-1.40.0-wmf.17/extensions/FlaggedRevs/frontend/FlaggedRevsUIHooks.php(192): FlaggablePageView->addStableLink()
#10 /srv/mediawiki/php-1.40.0-wmf.17/includes/HookContainer/HookContainer.php(338): FlaggedRevsUIHooks::onArticleViewHeader(Article, NULL, boolean)
#11 /srv/mediawiki/php-1.40.0-wmf.17/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#12 /srv/mediawiki/php-1.40.0-wmf.17/includes/HookContainer/HookRunner.php(850): MediaWiki\HookContainer\HookContainer->run(string, array)
#13 /srv/mediawiki/php-1.40.0-wmf.17/includes/page/Article.php(599): MediaWiki\HookContainer\HookRunner->onArticleViewHeader(Article, NULL, boolean)
#14 /srv/mediawiki/php-1.40.0-wmf.17/includes/page/Article.php(533): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#15 /srv/mediawiki/php-1.40.0-wmf.17/includes/actions/ViewAction.php(78): Article->view()
#16 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(551): ViewAction->show()
#17 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(328): MediaWiki->performAction(Article, Title)
#18 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(916): MediaWiki->performRequest()
#19 /srv/mediawiki/php-1.40.0-wmf.17/includes/MediaWiki.php(571): MediaWiki->main()
#20 /srv/mediawiki/php-1.40.0-wmf.17/index.php(50): MediaWiki->run()
#21 /srv/mediawiki/php-1.40.0-wmf.17/index.php(46): wfIndexMain()
#22 /srv/mediawiki/w/index.php(3): require(string)
#23 {main}
Impact
Notes

Details

MediaWiki Version
1.40.0-wmf.17
Request URL
https://ru.wikipedia.org/w/index.php?oldid=*&redirect=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace deprecated WikiPage::newFromIDmediawiki/coremaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

Zabe created this task.Jan 10 2023, 3:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2023, 3:17 PM
Lucas_Werkmeister_WMDE added a project: FlaggedRevs.Jan 10 2023, 3:24 PM
Umherirrender claimed this task.EditedJan 10 2023, 4:51 PM
Umherirrender subscribed.

Related to T297688

					if ( $this->mPage->getId() != $revPageId ) {
						$function = get_class( $this->mPage ) . '::newFromID';
						$this->mPage = $function( $revPageId );
					}

Hard to spot with code searches

gerritbot added a comment.Jan 10 2023, 5:01 PM

Change 878136 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Replace deprecated WikiPage::newFromID

https://gerrit.wikimedia.org/r/878136

gerritbot added a project: Patch-For-Review.Jan 10 2023, 5:01 PM
gerritbot added a comment.Jan 10 2023, 5:28 PM

Change 878136 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated WikiPage::newFromID

https://gerrit.wikimedia.org/r/878136

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2023, 5:29 PM
Umherirrender closed this task as Resolved.Jan 19 2023, 7:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits