I've been thinking about tag clutter after reading the discussions on T326399. It seems to me that the Source/Visual tags, added alongside Reply/New topic tags on DiscussionTools edits, provide very little value. I think editors don't really care about which mode the tool was in when the edit was saved, and they don't provide much debugging information since users can switch modes so easily. I think we should hide them (and perhaps stop adding them entirely).
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Hide the Source/Visual tags on DiscussionTools edits | mediawiki/extensions/DiscussionTools | master | +8 -8 |
Related Objects
Related Objects
- Mentioned Here
- T326399: (other edits) links repetitive and long
Event Timeline
Comment Actions
The kind of editor used has value as something to track at a high level (how many edits were from VE this month?).
It's probably also got some value for the source of bugs that VE is in the context of copy-pasting HTML from certain places and then substing templates. (Task exists over there somewhere.) When a visual edit drops a lot of text into a page, that's almost always caused by that issue and having that tag is a good indicator. (If there's a way to add a tag when VE gets content that it transforms and isn't sure if it should, that might be nice.)
At an everyday level in the context of troubleshooting we usually just ask how someone made an edit and it otherwise doesn't have a whole lot of value.
If there's value to removing them in DT, there's probably value to removing these tags everywhere.
@Whatamidoing-WMF might have a different opinion or know of other reasons to have editor kind as a tag.
Comment Actions
The kind of editor used has value as something to track at a high level (how many edits were from VE this month?).
It's probably also got some value for the source of bugs that VE is in the context of copy-pasting HTML from certain places and then substing templates.
+1 to the points, @Izno I raising above...
Assuming that in "hiding" the visual and source tags they will still be associated with/added to every edit so that we can continue to do things like the below then I support us making this change in service of the impact @matmarex described above. [i]
- Use Superset to see the percentage of comments / new topics people post using the tools' visual and source modes
- Learn what editing mode someone used to publish a particular edit
i. Decluttering page history
Comment Actions
Okay, I guess just hide then, and not remove.
Yes, this is unaffected.
- Learn what editing mode someone used to publish a particular edit
Yes, technically this remains possible, although rather impractical – you'll still be able to see the tag when using &uselang=qqx, e.g.:
(they will also still show up in API responses, and can be used when using filtering by tag on history/contributions/recentchanges)
Comment Actions
Change 881749 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Hide the Source/Visual tags on DiscussionTools edits
Comment Actions
Change 881749 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Hide the Source/Visual tags on DiscussionTools edits
Comment Actions
Since this was a localisation message that is now intended to not be localised, I'll need to check if I need to do anything about translations, or whether someone will take care of them when importing to Translatewiki.
Comment Actions
It was taken care of:
- Configuration was changed in https://gerrit.wikimedia.org/r/c/translatewiki/+/882721
- Translations were removed automatically in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/883027
Thanks @Raymond!