Page MenuHomePhabricator
Create Task
Maniphest T326690

PHP Deprecated: HTMLFormField::__construct: Constructing an HTMLFormField without a 'parent' parameter [Called from Licenses::__construct]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: HTMLFormField::__construct: Constructing an HTMLFormField without a 'parent' parameter [Called from Licenses::__construct]
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.18/includes/specials/formfields/Licenses.php(49)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.40.0-wmf.18/includes/debug/MWDebug.php(381): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.40.0-wmf.18/includes/debug/MWDebug.php(352): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.40.0-wmf.18/includes/GlobalFunctions.php(795): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.40.0-wmf.18/includes/htmlform/HTMLFormField.php(513): wfDeprecatedMsg(string, string)
#5 /srv/mediawiki/php-1.40.0-wmf.18/includes/specials/formfields/Licenses.php(49): HTMLFormField->__construct(array)
#6 /srv/mediawiki/php-1.40.0-wmf.18/extensions/3D/src/Hooks.php(57): Licenses->__construct(array)
#7 /srv/mediawiki/php-1.40.0-wmf.18/includes/HookContainer/HookContainer.php(338): MediaWiki\Extension\ThreeD\Hooks::onUploadFormInitDescriptor(array)
#8 /srv/mediawiki/php-1.40.0-wmf.18/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#9 /srv/mediawiki/php-1.40.0-wmf.18/includes/HookContainer/HookRunner.php(4021): MediaWiki\HookContainer\HookContainer->run(string, array)
#10 /srv/mediawiki/php-1.40.0-wmf.18/includes/specials/forms/UploadForm.php(122): MediaWiki\HookContainer\HookRunner->onUploadFormInitDescriptor(array)
#11 /srv/mediawiki/php-1.40.0-wmf.18/includes/specials/SpecialUpload.php(295): UploadForm->__construct(array, RequestContext, MediaWiki\Linker\LinkRenderer, LocalRepo, LanguageEn, NamespaceInfo, MediaWiki\HookContainer\HookContainer)
#12 /srv/mediawiki/php-1.40.0-wmf.18/includes/specials/SpecialUpload.php(457): SpecialUpload->getUploadForm(string, string, boolean)
#13 /srv/mediawiki/php-1.40.0-wmf.18/includes/specials/SpecialUpload.php(532): SpecialUpload->showUploadWarning(array)
#14 /srv/mediawiki/php-1.40.0-wmf.18/includes/specials/SpecialUpload.php(237): SpecialUpload->processUpload()
#15 /srv/mediawiki/php-1.40.0-wmf.18/includes/specialpage/SpecialPage.php(700): SpecialUpload->execute(NULL)
#16 /srv/mediawiki/php-1.40.0-wmf.18/includes/specialpage/SpecialPageFactory.php(1458): SpecialPage->run(NULL)
#17 /srv/mediawiki/php-1.40.0-wmf.18/includes/MediaWiki.php(322): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#18 /srv/mediawiki/php-1.40.0-wmf.18/includes/MediaWiki.php(916): MediaWiki->performRequest()
#19 /srv/mediawiki/php-1.40.0-wmf.18/includes/MediaWiki.php(571): MediaWiki->main()
#20 /srv/mediawiki/php-1.40.0-wmf.18/index.php(50): MediaWiki->run()
#21 /srv/mediawiki/php-1.40.0-wmf.18/index.php(46): wfIndexMain()
#22 /srv/mediawiki/w/index.php(3): require(string)
#23 {main}
Impact
Notes

Details

MediaWiki Version
1.40.0-wmf.18
Request URL
https://office.wikimedia.org/wiki/Special:Upload
SubjectRepoBranchLines +/-
Simplify expensive checkmediawiki/extensions/3Dwmf/1.40.0-wmf.18+3 -3
Simplify expensive checkmediawiki/extensions/3Dmaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Zabe created this task.Jan 10 2023, 11:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2023, 11:18 PM
Zabe added a project: MediaWiki-HTMLForm.Jan 10 2023, 11:28 PM
Zabe added subscribers: matmarex, Bawolff.

Seems to have been caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/876278.

Reedy edited projects, added 3D; removed MediaWiki-HTMLForm.Jan 10 2023, 11:30 PM
gerritbot added a comment.Jan 11 2023, 12:09 AM

Change 878224 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/3D@master] Simplify expensive check

https://gerrit.wikimedia.org/r/878224

gerritbot added a project: Patch-For-Review.Jan 11 2023, 12:09 AM
matmarex claimed this task.Jan 11 2023, 12:10 AM
matmarex added a parent task: T325581: 1.40.0-wmf.18 deployment blockers.Jan 11 2023, 2:53 AM

This will probably get pretty spammy on Commons… It'd be nice if someone could review the patch, so that we can backport it before the train deployment.

gerritbot added a comment.Jan 11 2023, 9:46 AM

Change 878224 merged by jenkins-bot:

[mediawiki/extensions/3D@master] Simplify expensive check

https://gerrit.wikimedia.org/r/878224

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 11 2023, 10:00 AM
gerritbot added a comment.Jan 11 2023, 10:15 AM

Change 878160 had a related patch set uploaded (by Zabe; author: Bartosz Dziewoński):

[mediawiki/extensions/3D@wmf/1.40.0-wmf.18] Simplify expensive check

https://gerrit.wikimedia.org/r/878160

gerritbot added a comment.Jan 11 2023, 10:20 AM

Change 878160 merged by jenkins-bot:

[mediawiki/extensions/3D@wmf/1.40.0-wmf.18] Simplify expensive check

https://gerrit.wikimedia.org/r/878160

Stashbot mentioned this in T233004: Update CheckUser for actor and comment table.Jan 11 2023, 10:21 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T10:21:24Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:878160|Simplify expensive check (T326690)]], [[gerrit:877249|Start reading from cuc_actor on test wikis (T233004)]]

Stashbot added a comment.Jan 11 2023, 10:23 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T10:23:13Z] <zabe@deploy1002> zabe and zabe: Backport for [[gerrit:878160|Simplify expensive check (T326690)]], [[gerrit:877249|Start reading from cuc_actor on test wikis (T233004)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Maintenance_bot removed a project: Patch-For-Review.Jan 11 2023, 10:30 AM
Stashbot added a comment.Jan 11 2023, 10:31 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T10:30:59Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:878160|Simplify expensive check (T326690)]], [[gerrit:877249|Start reading from cuc_actor on test wikis (T233004)]] (duration: 09m 34s)

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.18; 2023-01-09); removed MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 11 2023, 11:00 AM
Agusbou2015 subscribed.Jan 11 2023, 11:41 AM
jeena subscribed.Jan 11 2023, 5:31 PM

Is this resolved now?

matmarex closed this task as Resolved.Jan 11 2023, 5:47 PM

Yes, thanks for backporting @Zabe!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL