Page MenuHomePhabricator
Create Task
Maniphest T326738

DefaultView: Create ZCode component
Closed, ResolvedPublic
Actions

Description

Description

Create ZCode custom component following the same patterns as other default/* components created for the DefaultView

Desired behavior/Acceptance criteria

  • Objects of type Z16/Code should be rendered by default with this component in both edit and view mode
  • Must be able to view code using ace.js
  • Must be able to edit code using ace.js
  • Editing the language selector should effectively change the value of the Z16K1 key
  • Editing the code editor should effectively change the value of the Z16K2 key
  • Styles according to the attached designs* - couldn't find the designs for this
NOTE: There are no explicit designs for ZCode in the DefaultView figma file, but we should be able to easily reinterpret the functionality of the old ZCode component for the DefaultView

Devices and Design (URLs or screenshots)

Figma: https://www.figma.com/file/uNBSv1e4ceA8tGNr29R9vp/Default-component?node-id=3043%3A62307&t=HYKgOdmMUb1GV57x-0

Completion checklist

Details

SubjectRepoBranchLines +/-
Create ZCode component that can be displayed inline in DefaultViewmediawiki/extensions/WikiLambdamaster+431 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JKieserman created this task.Jan 11 2023, 4:02 PM
• JKieserman added a parent task: T324217: DefaultView: Create the minimum necessary components to have a fully functioning DefaultView.
gengh moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Jan 16 2023, 11:58 AM
gengh edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
gengh updated the task description. (Show Details)
gengh mentioned this in T327058: DefaultView: Create ZCode custom component.
gengh moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.Jan 16 2023, 12:00 PM
gerritbot added a comment.Jan 17 2023, 10:19 PM

Change 881012 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] Create ZCode component that can be displayed inline in DefaultView

https://gerrit.wikimedia.org/r/881012

gerritbot added a project: Patch-For-Review.Jan 17 2023, 10:19 PM
gengh moved this task from Ready: G5. Fallback view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Jan 23 2023, 4:40 PM
gerritbot added a comment.Jan 31 2023, 10:37 AM

Change 881012 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Create ZCode component that can be displayed inline in DefaultView

https://gerrit.wikimedia.org/r/881012

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Jan 31 2023, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 31 2023, 11:29 AM
DVrandecic closed this task as Resolved.Feb 2 2023, 9:08 PM
DVrandecic updated the task description. (Show Details)
Jdforrester-WMF merged a task: T327058: DefaultView: Create ZCode custom component.May 9 2023, 7:14 PM
Jdforrester-WMF added a subscriber: gengh.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL