Page MenuHomePhabricator
Create Task
Maniphest T326764

PHP Warning: substr() expects parameter 1 to be string, array given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: substr() expects parameter 1 to be string, array given
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.18/includes/search/SearchEngine.php(430)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.18/includes/search/SearchEngine.php(430): substr(array, integer, NULL)
#2 /srv/mediawiki/php-1.40.0-wmf.18/includes/search/SearchEngine.php(537): SearchEngine::parseNamespacePrefixes(array, boolean, boolean)
#3 /srv/mediawiki/php-1.40.0-wmf.18/includes/search/SearchEngine.php(600): SearchEngine->normalizeNamespaces(array)
#4 /srv/mediawiki/php-1.40.0-wmf.18/extensions/CirrusSearch/includes/CirrusSearch.php(466): SearchEngine->completionSearch(array)
#5 /srv/mediawiki/php-1.40.0-wmf.18/includes/Rest/Handler/SearchHandler.php(193): CirrusSearch\CirrusSearch->completionSearchWithVariants(array)
#6 /srv/mediawiki/php-1.40.0-wmf.18/includes/Rest/Handler/SearchHandler.php(387): MediaWiki\Rest\Handler\SearchHandler->doSearch(CirrusSearch\CirrusSearch)
#7 /srv/mediawiki/php-1.40.0-wmf.18/includes/Rest/Router.php(487): MediaWiki\Rest\Handler\SearchHandler->execute()
#8 /srv/mediawiki/php-1.40.0-wmf.18/includes/Rest/Router.php(406): MediaWiki\Rest\Router->executeHandler(MediaWiki\Rest\Handler\SearchHandler)
#9 /srv/mediawiki/php-1.40.0-wmf.18/includes/Rest/EntryPoint.php(191): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#10 /srv/mediawiki/php-1.40.0-wmf.18/includes/Rest/EntryPoint.php(131): MediaWiki\Rest\EntryPoint->execute()
#11 /srv/mediawiki/php-1.40.0-wmf.18/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#12 /srv/mediawiki/w/rest.php(3): require(string)
#13 {main}
Impact
Notes

Probably related to T326763: PHP Warning: strpos() expects parameter 1 to be string, array given

Details

Request URL
https://www.mediawiki.org/w/rest.php/v1/search/title?limit=*&q%5B0%5D=*&q%5B1%5D=*
ProjectBranchLines +/-Subject
mediawiki/coremaster+49 -0ParamValidator: Throw exception if there is a type to value mismatch
mediawiki/coremaster+7 -0ParamValidator: Validate and normalize `q` param to string
Customize query in gerrit

Related Objects

Event Timeline

jeena created this task.Jan 11 2023, 10:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2023, 10:01 PM
Reedy updated the task description. (Show Details)Jan 11 2023, 10:47 PM
Reedy added projects: MediaWiki-Search, CirrusSearch, Discovery-Search.
Reedy mentioned this in T326763: PHP Warning: strpos() expects parameter 1 to be string, array given.
Gehel moved this task from needs triage to Current work on the Discovery-Search board.Jan 16 2023, 4:03 PM
Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse merged a task: T326763: PHP Warning: strpos() expects parameter 1 to be string, array given.Jan 16 2023, 4:58 PM
dcausse edited projects, added MediaWiki-REST-API, Platform Engineering; removed Discovery-Search (Current work), CirrusSearch, MediaWiki-Search.Jan 16 2023, 5:06 PM
dcausse added a subscriber: dcausse.

I think that the REST handler accepts array parameters 'param[0]=value1&param[1]=value2' and then is passing an array all over the place while a string is expected. The action API does remove all these array params before doing anything else:

if ( $ret === null ) {
        if ( $this->getRequest()->getArray( $name ) !== null ) {
                // See T12262 for why we don't just implode( '|', ... ) the
                // array.
                $this->addWarning( [ 'apiwarn-unsupportedarray', $name ] );
        }
        $ret = $default;
}

We could hack \Wikimedia\ParamValidator\ParamValidator to detect such parameters but I feel that there're some missing sanity checks in the MW REST subsystem.

Untagging search as I don't think this is something specific to search.

thiemowmde added a subscriber: thiemowmde.Jan 18 2023, 10:18 AM

Yea: https://en.wikipedia.org/w/rest.php/v1/search/page?q[]=ouch. We could fix this in place by adding something line if ( is_array( $query ) ) { $query = reset( $query ); }. But there are some more places that might all have the same problem: https://codesearch.wmcloud.org/search/?q=getValidatedParams%5C(%5C)%5C%5B&files=%5C.php%24.

Umherirrender added a subscriber: Umherirrender.Jan 19 2023, 8:45 PM

Similiar to T304353 and the discussion there (T304353#7794614)

thcipriani moved this task from Untriaged to Jan 2023 on the Wikimedia-production-error board.Feb 9 2023, 4:50 PM
Umherirrender removed a subscriber: Umherirrender.Feb 10 2023, 7:43 PM
thcipriani mentioned this in T304353: PHP Warning: preg_match() expects parameter 2 to be string, array given.Apr 13 2023, 3:22 PM
thcipriani added a subscriber: thcipriani.
Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Warning: strpos() expects parameter 1 to be string, array given
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.3/includes/search/SearchEngine.php(406)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.41.0-wmf.3/includes/search/SearchEngine.php(406): strpos(array, string)
#2 /srv/mediawiki/php-1.41.0-wmf.3/includes/search/SearchEngine.php(538): SearchEngine::parseNamespacePrefixes(array, boolean, boolean)
#3 /srv/mediawiki/php-1.41.0-wmf.3/includes/search/SearchEngine.php(601): SearchEngine->normalizeNamespaces(array)
#4 /srv/mediawiki/php-1.41.0-wmf.3/extensions/CirrusSearch/includes/CirrusSearch.php(466): SearchEngine->completionSearch(array)
#5 /srv/mediawiki/php-1.41.0-wmf.3/includes/Rest/Handler/SearchHandler.php(193): CirrusSearch\CirrusSearch->completionSearchWithVariants(array)
#6 /srv/mediawiki/php-1.41.0-wmf.3/includes/Rest/Handler/SearchHandler.php(387): MediaWiki\Rest\Handler\SearchHandler->doSearch(CirrusSearch\CirrusSearch)
#7 /srv/mediawiki/php-1.41.0-wmf.3/includes/Rest/Router.php(517): MediaWiki\Rest\Handler\SearchHandler->execute()
#8 /srv/mediawiki/php-1.41.0-wmf.3/includes/Rest/Router.php(422): MediaWiki\Rest\Router->executeHandler(MediaWiki\Rest\Handler\SearchHandler)
#9 /srv/mediawiki/php-1.41.0-wmf.3/includes/Rest/EntryPoint.php(195): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#10 /srv/mediawiki/php-1.41.0-wmf.3/includes/Rest/EntryPoint.php(135): MediaWiki\Rest\EntryPoint->execute()
#11 /srv/mediawiki/php-1.41.0-wmf.3/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#12 /srv/mediawiki/w/rest.php(3): require(string)
#13 {main}
Notes

Noticed this this morning during log triage. Causes a cascade of errors for a small number of requests.

Pretty easy to recreate for testing: https://en.wikipedia.org/w/rest.php/v1/search/title?limit=1&q[0]=hi

One request triggers warnings about 2×strpos, strlen, mb_strlen, and 2×substr—six log messages per request.

gerritbot added a comment.Sun, May 21, 7:02 PM

Change 921762 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] ParamValidator: Validate and normalize `q` param to string

https://gerrit.wikimedia.org/r/921762

gerritbot added a project: Patch-For-Review.Sun, May 21, 7:02 PM
PatchDemoBot added a comment.Sun, May 21, 7:14 PM

Test wiki created on Patch demo by X-Savitar using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/17bb8aaba1/wiki/Main Page

xSavitar added a subscriber: xSavitar.Sun, May 21, 7:18 PM
In T326764#8869740, @PatchDemoBot wrote:

Test wiki created on Patch demo by X-Savitar using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/17bb8aaba1/wiki/Main Page

Tested on PD and it seems to work as expected.

gerritbot added a comment.Mon, May 22, 12:59 PM

Change 922119 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] ParamValidator: Throw exception if there is a type to value mismatch

https://gerrit.wikimedia.org/r/922119

gerritbot added a comment.Mon, May 22, 1:01 PM

Change 921762 abandoned by D3r1ck01:

[mediawiki/core@master] ParamValidator: Validate and normalize `q` param to string

Reason:

Going with the exception route: I507e5c4725b63d652771517ecd127da81082db31

https://gerrit.wikimedia.org/r/921762

gerritbot added a comment.Tue, May 30, 1:17 AM

Change 922119 merged by jenkins-bot:

[mediawiki/core@master] ParamValidator: Throw exception if there is a type to value mismatch

https://gerrit.wikimedia.org/r/922119

Maintenance_bot removed a project: Patch-For-Review.Tue, May 30, 1:29 AM
xSavitar closed this task as Resolved.Tue, May 30, 9:34 AM
xSavitar claimed this task.

This should be fine now. Please reopen if error still occurs.

Restricted Application added a project: User-xSavitar. · View Herald TranscriptTue, May 30, 9:34 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Tue, May 30, 1:01 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL