Phonos button can change spacing between lines when used in a paragraph
Closed, InvalidPublicBUG REPORT
Actions

Assigned To

None

Authored By

	dom_walden
	Jan 12 2023, 9:12 AM

Tags

Referenced Files

	F36169908: image.png
	Jan 12 2023, 5:27 PM

	F36168340: Screenshot from 2023-01-12 11-07-59.png
	Jan 12 2023, 4:12 PM

	F36153742: line-height_leading_without_phonos_safari16.png
	Jan 12 2023, 9:12 AM

	F36153740: line-height_leading_with_phonos_safari16.png
	Jan 12 2023, 9:12 AM

	F36153672: line-height_leading_without_phonos_chromium108.png
	Jan 12 2023, 9:12 AM

	F36153670: line-height_leading_with_phonos_chromium108.png
	Jan 12 2023, 9:12 AM

	F36089833: Screenshot 2023-01-10 at 11-35-09 Phonos Natural2 - Wikipedia the free encyclopedia.png
	Jan 12 2023, 9:12 AM
	File Not Attached

	F36089831: Screenshot 2023-01-10 at 11-34-44 Phonos Natural - Wikipedia the free encyclopedia.png
	Jan 12 2023, 9:12 AM
	File Not Attached

Subscribers

Description

What is the problem?

Using the Phonos button in a paragraph can change the spacing between the lines (leading?).

Browser	With Phonos	Without Phonos
Firefox 102
Chromium 108
Safari 16

All screenshots taken on Vector 2022.

For Chromium and Safari I used the expanded view, as otherwise the line breaks were different with and without Phonos, which made comparison difficult.

Steps to reproduce problem

Article used for testing:

with Phonos: https://en.wikipedia.beta.wmflabs.org/wiki/Phonos_Natural
without Phonos: https://en.wikipedia.beta.wmflabs.org/wiki/Phonos_Natural2

Environment

Browser: Firefox 102, Chromium 108, Safari 16 (on Browserstack)
Wiki(s): https://en.wikipedia.beta.wmflabs.org Phonos 0.1.0 (4323962) 07:25, 10 January 2023.

Related Objects

Mentioned In: T326781: Review text alignment of Phonos label compared to surrounding text
Mentioned Here: T320820: Phonos speaker icon placement moves on increased/reduced font size
rEPHN432396296b63: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Jan 12 2023, 9:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2023, 9:12 AM

Nardog subscribed.Jan 12 2023, 2:21 PM

I think this is expected, and not likely to have much push back from communities.

Template:IPAc-en on enwiki currently has similar flaws:

MusikAnimal mentioned this in T326781: Review text alignment of Phonos label compared to surrounding text.Jan 12 2023, 4:14 PM

In T326783#8520096, @MusikAnimal wrote:

I think this is expected, and not likely to have much push back from communities.

Template:IPAc-en on enwiki currently has similar flaws:

I'm not sure what you mean. What Phonos would replace is not the transcription but the "🔊 listen" part, which I don't think is responsible for the widening of the line. And in my environment, the presence of IPAc-en doesn't affect the spacing at all, presumably because the border-bottom is offset by the line height.

Making sure the Phonos button doesn't affect the line spacing (at least in default font size) does strike me as sensible. Ideally, the size of the icon should be proportional to the text (T320820: Phonos speaker icon placement moves on increased/reduced font size).

@dom_walden is this still an issue or can it be closed?

In T326783#8892606, @dmaza wrote:

@dom_walden is this still an issue or can it be closed?

I cannot reproduce it when I compared the two URLs from the description side by side, on Firefox and Chromium.

Closing per T326783#8948977. Thanks to whoever fixed this!

Phonos button can change spacing between lines when used in a paragraphClosed, InvalidPublicBUG REPORTActions