Can't press enter on mapframe fullscreen button in Chrome
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	thiemowmde
	Jan 12 2023, 9:54 AM

Project Tags

Referenced Files

None

Subscribers

Description

Steps to reproduce: Use Chrome (not Firefox). Go to a page that contains maps with static map thumbnails, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Maptests. Use the tab key to navigate to one of the maps. Try to press enter on the fullscreen button in the top right corner. Nothing happens.

Pressing enter when the map is focused works. But not the button. Both should work.

It seems to work when the map is dynamic, e.g. on https://de.wikivoyage.org/wiki/Pirna.

Demo for fix:
https://en.wikipedia.beta.wmflabs.org/wiki/Maptests/Nearby

Tab to fullscreen button and press enter.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Move "Show in full screen" tooltip to correct DOM element	mediawiki/extensions/Kartographer	master	+4 -2
	Don't tab to non-functional fullscreen button in static mode	mediawiki/extensions/Kartographer	master	+2 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T338318 Evaluate & improve accessibility of TechWish products
Open		None	T308320 Improve accessibility for Kartographer
Resolved	BUG REPORT	thiemowmde	T326786 Can't press enter on mapframe fullscreen button in Chrome

Event Timeline

thiemowmde created this task.Jan 12 2023, 9:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2023, 9:54 AM

thiemowmde added a parent task: T308320: Improve accessibility for Kartographer.Jan 12 2023, 9:57 AM

thiemowmde updated the task description. (Show Details)Jan 12 2023, 10:16 AM

lilients_WMDE mentioned this in T308320: Improve accessibility for Kartographer.Jan 12 2023, 10:42 AM

lilients_WMDE renamed this task from Can't press enter on mapframe fullscreen button to Can't press enter on mapframe fullscreen button in Chrome.Jan 12 2023, 1:38 PM

lilients_WMDE moved this task from Backlog to Ready for pickup on the WMDE-GeoInfo-FocusArea board.Jan 18 2023, 2:35 PM

JStrodt_WMDE subscribed.Jan 25 2023, 12:16 PM

Change 887737 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Don't tab to non-functional fullscreen button in static mode

https://gerrit.wikimedia.org/r/887737

gerritbot added a project: Patch-For-Review.Feb 8 2023, 10:19 AM

thiemowmde claimed this task.Feb 8 2023, 10:20 AM

thiemowmde set the point value for this task to 2.

thiemowmde moved this task from Ready for pickup to In sprint on the WMDE-GeoInfo-FocusArea board.

thiemowmde added projects: Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2023-01-18.

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-01-18 board.

thiemowmde added a subscriber: ECohen_WMDE.

lilients_WMDE moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-01-18 board.Feb 8 2023, 5:19 PM

Change 887737 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Don't tab to non-functional fullscreen button in static mode

https://gerrit.wikimedia.org/r/887737

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 8 2023, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2023, 6:30 PM

WMDE-Fisch updated the task description. (Show Details)Feb 13 2023, 7:59 AM

Change 888651 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Move "Show in full screen" tooltip to correct DOM element

https://gerrit.wikimedia.org/r/888651

gerritbot added a project: Patch-For-Review.Feb 13 2023, 11:04 AM

thiemowmde closed this task as Resolved.Feb 13 2023, 11:04 AM

Change 888651 merged by jenkins-bot: