Page MenuHomePhabricator

some installer fields should always be LTR
Closed, ResolvedPublic

Description

added 'dir'=>'ltr' to some fields

Some fields in the installer should always be dir="ltr" by default, because they are most likely Latin:

  • config-upload-deleted
  • config-db-name
  • config-db-prefix
  • config-upload-deleted
  • config-logo

In a rare case that some of these fields would be written in an RTL alphabet (an Arabic directory name, for instance), the user will be able to change the direction using Ctrl-Shift(-X).

Patch attached. It's my first PHP patch, so please be gentle :)


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz30679

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:52 PM
bzimport set Reference to bz30679.
bzimport added a subscriber: Unknown Object (MLST).

Patch applied in r96265.

It's sometimes hard to decide which fields should be LTR by default, imho..