Page MenuHomePhabricator
Create Task
Maniphest T326795

UserImpact: adjust language in the pageviews url to match the current user prefereces
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The pageviews url appends the impact data user (userlang=en) rather than the requesting user, Spanish

What should have happened instead?:
The pageviews url should append the requesting user language (userlang=es) rather than the impact data user, English

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Screenshot 2023-01-12 at 12.32.04.png (2×1 px, 342 KB)

Details

SubjectRepoBranchLines +/-
User impact: use the current user language in the pageviews urlmediawiki/extensions/GrowthExperimentsmaster+49 -24
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sgs created this task.Jan 12 2023, 11:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2023, 11:43 AM
Aklapper added a project: GrowthExperiments-ImpactModule.Jan 14 2023, 5:18 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 14 2023, 5:18 PM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.Jan 23 2023, 2:33 PM
kostajh added subscribers: KStoller-WMF, kostajh.

@KStoller-WMF would you us to fix this? If so could you please add it to an relevant Epic and the current sprint board?

KStoller-WMF triaged this task as Medium priority.Jan 26 2023, 2:49 PM
KStoller-WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
KStoller-WMF moved this task from Incoming to Top Product Priorities on the Growth-Team (Sprint 0 (Growth Team)) board.

Assuming this isn't overly complicated, this seems like a basic best practice we should follow. I've added to the current sprint / top product priorities.

KStoller-WMF added a parent task: T222310: [EPIC] Positive reinforcement: New Impact Module.Jan 26 2023, 2:51 PM
Sgs claimed this task.Jan 26 2023, 5:37 PM
Sgs moved this task from Top Product Priorities to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jan 30 2023, 4:43 PM

Change 884961 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: user the current user language in the pageviews url

https://gerrit.wikimedia.org/r/884961

gerritbot added a project: Patch-For-Review.Jan 30 2023, 4:43 PM
Sgs changed the task status from Open to In Progress.Jan 30 2023, 4:43 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 16 2023, 4:32 AM
gerritbot added a comment.Feb 16 2023, 4:52 AM

Change 884961 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: use the current user language in the pageviews url

https://gerrit.wikimedia.org/r/884961

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 16 2023, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 16 2023, 5:10 AM
Etonkovidova closed this task as Resolved.Feb 28 2023, 1:23 AM
Etonkovidova subscribed.

Checked in wmf.24 - the url looks correct now; the user lang preferences is reflected: https://pageviews.wmcloud.org/?project=test.wikipedia.org&userlang=es&start=2022-12-30&end=2023-02-27&pages=MavetunaZialnt30_2

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits