Maniphest T326804

Can not press enter on close button in map fullscreen
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	lilients_WMDE
	Jan 12 2023, 1:47 PM

Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Open a map in fullscreen mode.
Tab to close button at the right top corner.
Press enter.

What happens?:
Nothing

Demo for fix:
https://en.wikipedia.beta.wmflabs.org/wiki/Maptests/Nearby#/map/0

Tab to close button and press enter.

What should have happened instead?:
The map should close.

Other information (browser name/version, screenshots, etc.):
I tested in firefox and chrome. It seems to be broken on live as well as on beta.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make enter work on fullscreen map close button	mediawiki/extensions/Kartographer	master	+1 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T338318 Evaluate & improve accessibility of TechWish products
		Open		None	T308320 Improve accessibility for Kartographer
		Resolved	BUG REPORT	thiemowmde	T326804 Can not press enter on close button in map fullscreen

Event Timeline

lilients_WMDE created this task.Jan 12 2023, 1:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2023, 1:47 PM

lilients_WMDE updated the task description. (Show Details)Jan 12 2023, 1:48 PM

lilients_WMDE moved this task from Backlog to Ready for pickup on the WMDE-GeoInfo-FocusArea board.Jan 18 2023, 2:35 PM

JStrodt_WMDE subscribed.Jan 25 2023, 12:16 PM

thiemowmde claimed this task.Feb 8 2023, 10:01 AM

thiemowmde moved this task from Ready for pickup to In sprint on the WMDE-GeoInfo-FocusArea board.

thiemowmde added projects: Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2023-01-18.

thiemowmde set the point value for this task to 2.

Change 887736 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Make enter work on fullscreen map close button

https://gerrit.wikimedia.org/r/887736

gerritbot added a project: Patch-For-Review.Feb 8 2023, 10:06 AM

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-01-18 board.Feb 8 2023, 10:06 AM

lilients_WMDE moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-01-18 board.Feb 8 2023, 5:21 PM

Change 887736 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make enter work on fullscreen map close button

https://gerrit.wikimedia.org/r/887736

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 8 2023, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2023, 6:30 PM

WMDE-Fisch updated the task description. (Show Details)Feb 13 2023, 8:00 AM

thiemowmde closed this task as Resolved.Feb 13 2023, 10:44 AM

thiemowmde mentioned this in T374027: Kartographer doesn't close when you press "escape" after interacting with the map.Sep 11 2024, 9:55 AM