Page MenuHomePhabricator

Invalid property value of background-color for oo-ui-toggleButtonWidget
Closed, DuplicatePublicBUG REPORT

Description

For example, in oojs-ui-widgets-wikimediaui.css:

.oo-ui-toggleButtonWidget.oo-ui-widget-enabled.oo-ui-buttonElement-frameless.oo-ui-toggleWidget-on .oo-ui-buttonElement-button {
  background-color: rgba(0, 36, 73, 21/255);
  color: #000;
}

21/255 is invalid for rgba().
Noticed in commit c3dc0a2d99ed6bb594dec7cd5095085028696588.

Software version (skip for WMF-hosted wikis like Wikipedia):
Since OOUI 0.42.0

Event Timeline

So, somehow wikimedia-ui-base.less was not updated in the MediaWiki core for 2 previous OOUI updates?
It was bumped to 20.0 by commit a222a13 which contains the fix (3e13426), and then we have cd023d2 and e1d7d17 in the ooui side, f8a7e46 and fc0acab3 in the core.
What's the process of upgrading ooui in the core? manually? without CI checking?