Page MenuHomePhabricator

Update GlobalUsage extension to work with merge of iwtransclusion into core
Closed, DeclinedPublic

Description

r95396 merged the iwtransclusion branch into core, bringing some somewhat duplicate code from the GlobalUsage extension

I've asked Peter about this, but it needs tidying up, due to clashing class names, and quite a lot of duplicate/only slightly modified code

The classes in question are GlobalUsageQuery in both, and then SpecialGlobalUsage in the extension and GlobalFileUsage in phase3


Version: unspecified
Severity: normal

Details

Reference
bz30686

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:52 PM
bzimport added a project: GlobalUsage.
bzimport set Reference to bz30686.
bzimport added a subscriber: Unknown Object (MLST).

peter017 wrote:

The plan when I was developing the iwtransclusion branch one year ago was actually to have the GlobalUsage extension built-in.

That's why I copied a lot of code from it to the core. IIRC, this code would be shared by both images global usage and templates global usage.

The idea was that templates global usage would be built-in anyway so it did not seem more expensive to have images global usage built-in as well...

Bryan.TongMinh wrote:

Was reverted in r98467.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:12 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:22 AM