Page MenuHomePhabricator

Reconsider placement of rollback, thank and undo button in Watchlist Diff view on Android
Closed, ResolvedPublic


Background (what you would like to be able to do and where):
In regards to the undo/rollback/thank setup, I don't think putting rollback on the overflow menu is nessecarily the best idea because usually the advantage of rollback compared to a regular undo is the speed of it. On the other hand, people worry about accidently using the tool when they don't want to. People will sometimes customize their watchlist on desktop to get rid of rollback for this reason (see Wikipedia:Customizing watchlists#Remove or modify the rollback link). That was my main concern with the variance in the button placement on whether you're reverting an IP or another registered user as it's possible that mistakes are more likely to happen that way. I understand your point about how having everything together would be crowded, though. Maybe some way of customizing it in settings would be helpful? Or making the buttons vertical instead of horizontal? Something like 'undo' and 'rollback' for IPs and 'thanks', 'undo' and 'rollback' for registered users? That way, if someone accidently presses something, it's more likely to be undo instead of rollback - @Clovermoss

Feature summary (what you would like to be able to do and where):
Have consistent placement of undo, rollback and thank button in the diff view in the Android app


Change the UI elements of the button so it is more clear


undo + rollback v2.png (1×720 px, 120 KB)

Event Timeline

Assigning to @scblr for the rollback, undo, Thanks Design and I'll separately create a task for sending folks to the edit screen when hitting undo

@JTannerWMF – I added the screen with both the undo and rollback button to the task’s description.

@Dbrant undo looks fine. I am trusting you on the "rollback" button design and moving it to code review.

I think I have rollback rights on Test wiki but the rollback option isn't appearing for me for articles on Test Wiki @Dbrant