IP Masking will affect lots of our products, features, tools, gadgets, etc. This task is for tracking work to update those that are owned by The-Wikipedia-Library Team, ahead of IP Masking being enabled on WMF sites.
See T326816: [Epic] Update features for temporary accounts, particularly What will be affected.
A preliminary investigation (T326759) has found that the following may be affected:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| Resolved | Niharika | T324492 Temporary accounts - MVP | |||
| Resolved | Madalina | T326816 [Epic] Update features for temporary accounts | |||
| Resolved | Samwalton9-WMF | T339244 Update Moderator Tools-owned products that may be affected by IP Masking | |||
| Resolved | Samwalton9-WMF | T326909 Update Wikipedia Library products that may be affected by IP Masking | |||
| Resolved | jsn.sherman | T332552 Update TheWikipediaLibrary extension for IP masking | |||
| Open | None | T342091 Write setup documentation for setting up TheWikipediaLibrary extension locally | |||
| Resolved | Scardenasmolinar | T332553 Investigate whether the Library Card platform will be affected by IP masking | |||
| Resolved | Scardenasmolinar | T342090 Investigate whether the Wikilink tool will be affected by IP masking |
Looks like this is the only piece of code getting flagged here: https://gerrit.wikimedia.org/g/mediawiki/extensions/TheWikipediaLibrary/+/01f90ceca6b40ef2f2cdee021065a0d9b48f3bc1/includes/EchoHelper.php#38
Since notifications are only sent to registered users, and reading T326816, I assume this isn't going to affect the TheWikipediaLibrary extension at all. Do you see any potential issues here @jsn.sherman?
I think we're okay since we check for sul attachment pretty early on, but it would be pretty easy to test locally just to be on the safe side.