Page MenuHomePhabricator

Update Web Team-owned products that may be affected by IP Masking
Closed, ResolvedPublic


IP Masking will affect lots of our products, features, tools, gadgets, etc. This task is for tracking work to update those that are owned by Web Team, ahead of IP Masking being enabled on WMF sites.

See T326816: Update features for IP Masking, particularly What will be affected.

A preliminary investigation (T326759) has found that the following may be affected:

  • CologneBlue
  • MinervaNeue
  • MobileFrontend
  • MonoBook
  • Nostalgia
  • Popups
  • QuickSurveys
  • Vector
  • Timeless

Developer notes


// Defaults

$wgAutoCreateTempUser['enabled'] = true;

Event Timeline

Unfortunately I can't make our meeting tomorrow, but from a technical perspective acting as tech lead to the web team, I'd like to note that I'm not too happy with the existing UI permutation we have on the server side for Vector. We're not testing it, and we already have a considerable amount of variations of the Vector 2022 UI.

Since we are proposing doing this for MinervaNeue too (T307054) I'd be interested in undoing the changes we already made inside Vector (I8ac5de82f76a9ec58b0fbef85546bc7fd5b793d2, T300263) and instead recommend a minimal generic approach to add temporary account support inside MediaWiki core's Skin code. Once we've worked on timeline, I think web should own making that change happen with IP masking team signing off.

I think our goal here should be no changes to Timeless, Monobook and CologneBlue, Nostaglia as these are logged in only skins and I want to avoid having to patch every skin individually. This would also save us introducing a big disruptive change to 3rd party skins and gadget developers which would be damaging to the trust web team has been building.

Jdlrobson updated the task description. (Show Details)
Jdlrobson claimed this task.

I've gone through our features and the mocks and created explicit tickets for all the decisions we need to make regarding our projects:

  • T330510 - IP masking: Should account creation be more prominent for temporary users?
  • T330509 - Should Echo be available to IP masked users?
  • T330513 - IP masking: Minerva missing create account
  • T330515 - IP masking: Minerva links to non-existent user page
  • T330517 - IP masking: IP masked users cannot disable page previews

WikidataPageBanner, RelatedArticles do not require any changes.

Note, in QuickSurveys the only impact is that there is currently no way to target IP masked users with surveys. I figure that's a feature request that can be dealt with if and when needed so I haven't created a bug.

Regarding non default skins - Timeless, Monobook, Modern, Nostalgia and CologneBlue:
There will be no supported way on Wikimedia sites to access these skins as anonymous users so I think the status quo is acceptable and no changes are needed. Nostalgia is the most impacted given its legacy codebase, it shows a logout link. Here's how those skins look for reference:

Screen Shot 2023-02-24 at 9.40.00 AM.png (1×2 px, 877 KB)
Screen Shot 2023-02-24 at 9.40.35 AM.png (1×2 px, 916 KB)
Screen Shot 2023-02-24 at 9.41.02 AM.png (1×2 px, 981 KB)
Screen Shot 2023-02-24 at 9.41.25 AM.png (1×2 px, 1 MB)
Screen Shot 2023-02-24 at 9.43.01 AM.png (1×2 px, 1 MB)