Page MenuHomePhabricator

[SPIKE] Investigate MassMessage extension to see if changes are required for IP Masking
Closed, ResolvedPublic

Description

A preliminary investigation (T326759) has found that the MassMessage extension may be affected by IP Masking

Acceptance criteria
  • As a developer
    • I would like to know of all of the parts of the MassMessage extension that are affected by IP Masking
    • And this should be documented once a thorough investigation has been performed

Timebox: 3 hours

Design

N/A

External dependencies
Other dependencies

https://www.mediawiki.org/wiki/Help:Temporary_accounts/How_it_works

Event Timeline

The campaigns team will take care of this extension.

MHorsey-WMF renamed this task from Prepare MassMessage extension for IP Masking to [SPIKE] Investigate MassMessage extension to see if changes are required for IP Masking.Jun 29 2023, 1:20 PM
MHorsey-WMF updated the task description. (Show Details)
MHorsey-WMF updated the task description. (Show Details)

I've analysed the code base, and the only thing I could find that might need to be updated is:

MassMessageJob.php line 341
$user = User::newFromName( $title->getRootText() );
if ( !$user || !$user->getId() ) { // Does not exist

MassMessage doesn't allow posting messages to anon talk pages. I believe it should also not allow posting to temp user talk pages.

In particular, note that the call to User::getId() in MassMessageHooks.php and that to User::isRegistered() in MassMessage.php don't have to be updated.

@Daimona can you create a task for the change please?

@Daimona can you create a task for the change please?

Done: T341473: Update the MassMessage extension for IP masking

Resolving this task as the spike was completed.