Page MenuHomePhabricator

Prepare SandboxLink extension for IP Masking
Closed, ResolvedPublic

Description

A preliminary investigation (T326759) has found that the SandboxLink extension may be affected by IP Masking

Event Timeline

It looks like temp users get a "Sandbox" link. Demo here: https://patchdemo.wmflabs.org/wikis/943db8aa7e/wiki/Main_Page

image.png (2×3 px, 169 KB)

(It also appears in the wrong place, compared to a logged in user:)

image.png (2×3 px, 155 KB)

They probably shouldn't get the link, like logged out users:

image.png (2×3 px, 139 KB)

Although in theory logged out users can have a sandbox, and I suppose temp users could too, we probably don't want to encourage them to create one. It'd be easy to lose when your IP changes / temp account session ends.

Change 879842 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/SandboxLink@master] Disable sanbox links for temp users by default as well

https://gerrit.wikimedia.org/r/879842

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/49181f1fc7/w

Change 879842 merged by jenkins-bot:

[mediawiki/extensions/SandboxLink@master] Disable sanbox links for temp users by default as well

https://gerrit.wikimedia.org/r/879842

Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/49181f1fc7/w/