A preliminary investigation (T326759) has found that the SandboxLink extension may be affected by IP Masking
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Disable sanbox links for temp users by default as well | mediawiki/extensions/SandboxLink | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| Resolved | Niharika | T324492 Temporary accounts - MVP | |||
| Open | None | T326816 [Epic] Update features for temporary accounts | |||
| Resolved | matmarex | T326927 Prepare SandboxLink extension for IP Masking |
Event Timeline
It looks like temp users get a "Sandbox" link. Demo here: https://patchdemo.wmflabs.org/wikis/943db8aa7e/wiki/Main_Page
(It also appears in the wrong place, compared to a logged in user:)
They probably shouldn't get the link, like logged out users:
Although in theory logged out users can have a sandbox, and I suppose temp users could too, we probably don't want to encourage them to create one. It'd be easy to lose when your IP changes / temp account session ends.
Change 879842 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/SandboxLink@master] Disable sanbox links for temp users by default as well
Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/49181f1fc7/w
Change 879842 merged by jenkins-bot:
[mediawiki/extensions/SandboxLink@master] Disable sanbox links for temp users by default as well
Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:


