Page MenuHomePhabricator
Create Task
Maniphest T326939

Prepare WikimediaIncubator extension for IP Masking
Closed, ResolvedPublic
Actions

Description

A preliminary investigation (T326759) has found that the WikimediaIncubator extension may be affected by IP Masking

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Filter temporary accounts from dropdown on Special:ViewUserLangAmdrelmediawiki/extensions/WikimediaIncubatormaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Jan 13 2023, 10:18 AM
• TAdeleye_WMF edited projects, added: Trust and Safety Product Team; removed: Anti-Harassment-Team.May 14 2024, 4:15 PM
Tchanders edited projects, added: Temporary accounts (Update unowned extensions); removed: Temporary accounts.Jun 11 2024, 5:04 PM
Amdrel subscribed.Aug 15 2024, 9:07 PM

It looks like the user search text field in Special:ViewUserLang needs to be updated to filter out temporary users since the form disallows showing their lang setting already. If https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1054961 gets accepted and merged then this will be possible by passing excludetemp to the descriptor that creates the search box.

kostajh assigned this task to Amdrel.Aug 21 2024, 8:13 AM
kostajh subscribed.
In T326939#10068107, @Amdrel wrote:

It looks like the user search text field in Special:ViewUserLang needs to be updated to filter out temporary users since the form disallows showing their lang setting already. If https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1054961 gets accepted and merged then this will be possible by passing excludetemp to the descriptor that creates the search box.

Thanks! Could you make a patch that uses Depends-On to the core patch, please?

gerritbot added a comment.Aug 21 2024, 5:43 PM

Change #1064433 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/WikimediaIncubator@master] Filter temporary accounts from dropdown on Special:ViewUserLang

https://gerrit.wikimedia.org/r/1064433

gerritbot added a project: Patch-For-Review.Aug 21 2024, 5:43 PM
Amdrel changed the task status from Open to In Progress.Aug 21 2024, 5:47 PM

Sure thing! I added a patch that adds the 'excludetemp' filter to the dropdown.

kostajh added a project: Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).Sep 3 2024, 10:34 AM
kostajh moved this task from Priority Backlog to Done on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.

Pending merge of core patch, but otherwise, it's done.

gerritbot added a comment.Sep 19 2024, 10:08 AM

Change #1064433 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Filter temporary accounts from dropdown on Special:ViewUserLang

https://gerrit.wikimedia.org/r/1064433

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2024, 10:31 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.24; 2024-09-24).Sep 19 2024, 11:00 AM
kostajh closed this task as Resolved.Oct 1 2024, 9:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits